Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • V virglrenderer
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 90
    • Issues 90
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 34
    • Merge requests 34
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • virgl
  • virglrenderer
  • Merge requests
  • !630

vkr: use the newer hash_table

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Chia-I Wu requested to merge olv/virglrenderer:vkr-hash-table into master Oct 11, 2021
  • Overview 7
  • Commits 8
  • Pipelines 6
  • Changes 11

The first 2 commits convert the resource table to use hash_table. The following 3 commits convert the object table. The last 3 commits revert a virglrenderer-specific customization to util_hash_table.

util_hash_table has a comment that says

Just uses the cso_hash for now, but it might be better switch to a linear probing hash table implementation at some point -- as it is said they have better lookup and cache performance and it appears to be possible to write a lock-free implementation of such hash tables .

The newer hash_table uses linear probing. In Mesa, util_hash_table has also become a wrapper of hash_table, although no one cared enough to benchmark.

/cc @zzyiwei @ryanneph

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: vkr-hash-table