Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • V virglrenderer
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 90
    • Issues 90
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 33
    • Merge requests 33
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • virgl
  • virglrenderer
  • Merge requests
  • !614

vrend: make sure color read from a buffer is always unclamped

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Italo Nicola requested to merge italove/virglrenderer:alt-fix-clamp-color into master Sep 13, 2021
  • Overview 5
  • Commits 1
  • Pipelines 14
  • Changes 1

Tipically mesa handles CLAMP_READ_COLOR in gallium frontend, and the default value for CLAMP_READ_COLOR as defined by the GL spec is GL_FIXED_ONLY.

As CLAMP_READ_COLOR is really only used for reading pixel color values from a buffer, there's no problem always returning unclamped colors and letting the guest mesa clamp it if it wants.

If on the other hand, we clamp it on the host, as we do now, then the guest mesa only has clamped values to work with, which needless to say, can't be "unclamped".

Fixes piglit's fbo-blending-snorm tests on the GL backend, but with GL ES it's still broken.

Edited Sep 13, 2021 by Italo Nicola
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: alt-fix-clamp-color