Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • V virglrenderer
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 88
    • Issues 88
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 35
    • Merge requests 35
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • virgl
  • virglrenderer
  • Merge requests
  • !48

shader: correct swizzles from TGSI_SEMANTIC_SAMPLEPOS

  • Review changes

  • Download
  • Patches
  • Plain diff
Closed Erik Faye-Lund requested to merge kusma/virglrenderer:fix-samplepos-swizzles into master Oct 02, 2018
  • Overview 5
  • Commits 1
  • Pipelines 0
  • Changes 1

TGSI defines TGSI_SEMANTIC_SAMPLEPOS as a 4-component vector with Z and W set to 0. However, if we ever try to reach thez and w compoents, we run into trouble because this is implemented as a swizzle on gl_SamplePosition instead. And gl_SamplePosition only has x and y.

It seems that recent versions of mesa does just this, causing shader-compilation errors during dEQP tests.

This fixes regressions in the following tests:

  • dEQP-GLES31.functional.shaders.sample_variables.sample_pos.correctness.singlesample_texture
  • dEQP-GLES31.functional.shaders.sample_variables.sample_pos.correctness.multisample_texture_1
  • dEQP-GLES31.functional.shaders.sample_variables.sample_pos.correctness.multisample_texture_2
  • dEQP-GLES31.functional.shaders.sample_variables.sample_pos.correctness.multisample_texture_4
  • dEQP-GLES31.functional.shaders.sample_variables.sample_pos.correctness.multisample_texture_8
  • dEQP-GLES31.functional.shaders.sample_variables.sample_pos.correctness.singlesample_rbo
  • dEQP-GLES31.functional.shaders.sample_variables.sample_pos.correctness.multisample_rbo_1
  • dEQP-GLES31.functional.shaders.sample_variables.sample_pos.correctness.multisample_rbo_2
  • dEQP-GLES31.functional.shaders.sample_variables.sample_pos.correctness.multisample_rbo_4
  • dEQP-GLES31.functional.shaders.sample_variables.sample_pos.correctness.multisample_rbo_8
  • dEQP-GLES31.functional.shaders.sample_variables.sample_pos.distribution.multisample_texture_1
  • dEQP-GLES31.functional.shaders.sample_variables.sample_pos.distribution.multisample_texture_2
  • dEQP-GLES31.functional.shaders.sample_variables.sample_pos.distribution.multisample_texture_4
  • dEQP-GLES31.functional.shaders.sample_variables.sample_pos.distribution.multisample_texture_8
  • dEQP-GLES31.functional.shaders.multisample_interpolation.interpolate_at_offset.at_sample_position.default_framebuffer

Signed-off-by: Erik Faye-Lund erik.faye-lund@collabora.com

Edited Oct 03, 2018 by Erik Faye-Lund
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: fix-samplepos-swizzles