Skip to content

vkr: Prevent app from rebinding vkr_queue::ring_idx

Lina Versace requested to merge linyaa/virglrenderer:fix-leaked-vkr-queue-sync-thread into main

Fixes a bug. If the app tried to bind the queue to a different ring (by calling vkGetDeviceQueue2 with a new unused VkDeviceQueueTimelineInfoMESA::ringIdx), then vkr allowed it and leaked the sync thread of the queue's original ring.

Testing:

  • Play-tested with Hades DXVK.
  • Tested a little proof-of-concept app that rebound the ringIdx. Vanilla virglrenderer crashed. Patched virglrenderer logged the expected error messages in this branch and gracefully exited.

Closes: https://gitlab.freedesktop.org/virgl/virglrenderer/-/issues/375

Edited by Lina Versace

Merge request reports