Skip to content
Snippets Groups Projects

vtest: Add option to catch and return child process exit status

Closed vtest: Add option to catch and return child process exit status
wallbraker/virglrenderer:vtest-sigchld into main
3 unresolved threads
Closed Jakob Bornecrantz requested to merge wallbraker/virglrenderer:vtest-sigchld into main
3 unresolved threads

This commit is based on !108 (merged) and a part of my work to get dEQP/Volt to launch and monitor vtest for crashes as can currently be lost. And a vtest crash is in most cases also a VM crash.

Cheers, Jakob.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
vtest/vtest_server.c
177 static void handler_sigchld(int sig, siginfo_t *si, void *unused)
170 178 {
171 (void)sig; (void)si, (void)unused;
179 int wstat, exit_status;
180 pid_t pid;
172 181
173 printf("SIGSEGV!\n");
174 exit(EXIT_FAILURE);
182 (void)si, (void)unused;
183
184 if (sig != SIGCHLD) {
185 printf("Caught wrong signal?!\n");
186 exit(EXIT_FAILURE);
187 }
188
189 pid = wait3(&wstat, WNOHANG, NULL);
  • Gurchetan Singh
    Gurchetan Singh @gurchetansingh started a thread on the diff
    • vtest/vtest_server.c
    170 178 {
    171 (void)sig; (void)si, (void)unused;
    179 int wstat, exit_status;
    180 pid_t pid;
    172 181
    173 printf("SIGSEGV!\n");
    174 exit(EXIT_FAILURE);
    182 (void)si, (void)unused;
    183
    184 if (sig != SIGCHLD) {
    185 printf("Caught wrong signal?!\n");
    186 exit(EXIT_FAILURE);
    187 }
    188
    189 pid = wait3(&wstat, WNOHANG, NULL);
    190 if (pid == 0) {
  • Gurchetan Singh
    Gurchetan Singh @gurchetansingh started a thread on the diff
    • vtest/vtest_server.c
    62 64 .out_fd = -1,
    63 65 .do_fork = true,
    64 66 .loop = true,
    67 .catch_sigchld = false,
  • Jakob Bornecrantz added waiting-for-changes label

    added waiting-for-changes label

  • Gert Wollny changed target branch from master to main

    changed target branch from master to main

  • Gert Wollny
    Gert Wollny @gerddie ·
    Owner

    Bitrotten and ATM of not much interest, closing.

  • Gert Wollny closed

    closed

    • Please register or sign in to reply