Skip to content
Snippets Groups Projects
Commit 8c01a6de authored by Alyssa Rosenzweig's avatar Alyssa Rosenzweig Committed by Eric Engestrom
Browse files

lima,panfrost: Correct pixel vs block mismatches


Different parts of our codebase disagree on whether spatial
coordinates/dimensions are given in pixels or blocks, which differ by a
constant factor for block-compressed formats. This disagreement
manifests as incorrect results accessing block-compressed formats.

To resolve this, define the public tiling routines to take their
coordinates in pixels, and align the relevant code in Panfrost
accordingly.

Fixes rendering glitches in Factorio, as well as a pile of piglits on
Panfrost. It should also fix glTexSubImage() with ETC1 on Lima, but
there are no tests for this in dEQP/Piglit.

Signed-off-by: default avatarAlyssa Rosenzweig <alyssa@collabora.com>
Reviewed-by: Emma Anholt's avatarEmma Anholt <emma@anholt.net>
Tested-by: Vasily Khoruzhick <anarsoul@gmail.com> [dEQP/Lima]
Tested-by: Erico Nunes <nunes.erico@gmail.com> [Piglit/Lima]
Reported-by: default avatarIcecream95 <ixn@disroot.org>
Closes: #5560
Cc: mesa-stable
Part-of: <mesa/mesa!14370>
(cherry picked from commit b920ace4)
parent 0d427406
No related branches found
No related tags found
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment