Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • U upower
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 62
    • Issues 62
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 7
    • Merge requests 7
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • upower
  • upower
  • Merge requests
  • !49

Charging thresholds

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Ian Douglas Scott requested to merge ids1024/upower:charging-thresholds into master Sep 23, 2020
  • Overview 49
  • Commits 1
  • Pipelines 6
  • Changes 5

The kernel sysfs-class-power specifies charge_control_{start,end}_threshold as a standard way to get and set thresholds for charging. These are supported on some laptops.

I've started on an implementation, so I thought I might as well most it as a WIP merge request. But I have some questions about how/whether UPower should offer the necessary functionality:

  • Reading charging thresholds is much the same as any of the other properties that are currently offered. But I suppose setting should require polkit authentication? Is that currently in-scope for UPower?
    • Looking at the commit history, it seems UPower used to rely on PolKit, but doesn't any more now that features like suspend have been removed in favor of logind.
    • If it isn't appropriate for UPower, would any other daemon be more appropriate? Logind isn't relevant for this sort of thing.
  • How should the dbus API be specified? Everything else is defined as a property, but:
    • I'm not sure if a settable property would work with authentication though polkit... maybe.
    • Only some hardware would support this, so it might be desirable to expose this fact in some way.

Related: #117 #118

Edited Nov 12, 2020 by Ian Douglas Scott
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: charging-thresholds