Mario Limonciello authored 1 month ago and Marco Trevisan committed 1 month ago

This is new to 6.14. Currently PPD recognizes this as "cool"

Mario Limonciello authored 1 month ago and Marco Trevisan committed 1 month ago

|ppd mode    | charger  |
|------------|----------|
|power-saver | trickle  |
|balanced    | standard |
|performance | fast     |

Also, avoid changing if already set to adaptive as well.

Co-Authored-By: Marco Trevisan <mail@3v1n0.net>

Mario Limonciello authored 1 month ago and Marco Trevisan committed 1 month ago

When configured as 'Custom' PPD will stomp on other software's changes.
Check explicitly for this value and avoid making changes while it's set.

This is a short term solution.  Longer term a new upower API will be used.

Closes: #177

This will allow DE environments to decide whether they want to allow
actions and profiles to dynamically change from the battery level or
AC adapter presence.

While in power-saver mode the clock changes are reported to be too
aggressive for some users requested behavior.

Change the action to opt-in so that users that want to use it
can still enable it.

Fixes: #164

This information is stored in the new 'Actions' group in the keyfile.
If missing for any action, then use the value for 'optin' specified
in the action.

Only show this in the modern interface.

Default to disabled

This action will currently default to enabled.

This action will currently default to enabled.

Actions now have additional fields:
* "Description": A user friendly string to explain what an action does
* "Optin": Whether an action should default enabled or disabled
* "Active": Whether an action is enabled or disabled

These fields will be used for controlling the lifecycle of action.
Matching helpers for the core to call are also provided.

Mario Limonciello authored 5 months ago and Mario Limonciello committed 2 months ago

Rather than checking for active mode at startup and then never checking
it again check the mode when trying to write a value.

If it's not active, log something to the journal. This is intentionally
not failing because users could still have an ACPI platform-profile change
occur.

Fixes: #168

PPD doesn't force the SoC to active mode or to load.

As the policy of whether amd-pstate is loaded is controlled by the
kernel having another policy whether power-profiles-daemon isn't
necessary.

Do only monitor the battery percentage changes if an action or a driver
needs it

We don't need to do it for each proxy since they're all monitoring
the same owner.

So basically make the first proxy to be setup to win, not connecting to
the signal if the other is already set

Mario Limonciello authored 6 months ago and Marco Trevisan committed 6 months ago

This should fix a possible stack trace of an unset error variable.

Mario Limonciello authored 6 months ago and Marco Trevisan committed 6 months ago

Due a firmware bug on some OEM systems the amd-pstate kernel driver
starts up in active mode but EPP writes don't work.

Admittedly this is a kernel bug that it still advertises support and
it could be handled better by the kernel, but PPD can also validate
writes with a no-op for each CPU at bootup.

Do this to ensure that the CPU driver is only setup if we know it works.

Mario Limonciello authored 7 months ago and Marco Trevisan committed 6 months ago

When in power-saver set DPM clocks explicitly down to "low".

Fixes: #158

Mario Limonciello authored 7 months ago and Marco Trevisan committed 6 months ago

This will allow more actions to use a CPU check

Storing this information will be required to later support potentially
hotplugging drivers and features.

More users use power saver as their default value than expected, and
so ABM is a more negative experience for some of them.

Instead of a table of values, use "progressive" values that change
based on battery life.

The selected values:
* Balanced + AC:
  ABM 0
* Balanced + battery:
  >= 30% battery
    ABM 0
  < 30% battery
    ABM 1
* Power Saver + AC:
  ABM 0
* Power Saver + battery:
  >= 50% battery
    ABM 0
  30-49% battery
    ABM 1
  20-30% battery
    ABM 2
  <20% battery
    ABM 3

This will allow actions and drivers to react to battery level changes.

Although the system will save more power at lower frequency, AMD SoCs
have a point when they can operate most efficiently called the lowest
non-linear frequency.

Program the minimum frequency to this value in balanced and performance
modes to improve responsiveness.

Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>