Skip to content
Snippets Groups Projects
Commit 10e06064 authored by Vincent Penquerc'h's avatar Vincent Penquerc'h
Browse files

avaudenc: add a comment about using -1 in _finish_frame

See https://bugzilla.gnome.org/show_bug.cgi?id=729268
parent 17e2e9ac
No related branches found
No related tags found
Loading
......@@ -554,6 +554,9 @@ gst_ffmpegaudenc_encode_audio (GstFFMpegAudEnc * ffmpegaudenc,
codec = ffmpegaudenc->context->codec;
if ((codec->capabilities & CODEC_CAP_VARIABLE_FRAME_SIZE) || !audio_in) {
/* FIXME: Not really correct, as -1 means "all the samples we got
given so far", which may not be true depending on the codec,
but we have no way to know AFAICT */
ret = gst_audio_encoder_finish_frame (enc, outbuf, -1);
} else {
ret = gst_audio_encoder_finish_frame (enc, outbuf, frame.nb_samples);
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment