Skip to content
Snippets Groups Projects
Commit 17b0af73 authored by Jan Schmidt's avatar Jan Schmidt
Browse files

flvmux: Fix invalid padlist accesses.

Request pads can released at any time, so make sure to hold
the object lock when iterating the element sinkpads list where
that's safe, or to use other safe pad iteration patterns in
other places.

When choosing a best pad, return a reference to the pad to make sure it
stays alive for output in the aggregator srcpad task.

Should fix a spurious valgrind error in the CI flvmux tests and some
other potential problems if the request sink pads are released while
the element is running..

Fixes gstreamer/gst-plugins-good#714
parent d9aaa15a
No related branches found
No related tags found
No related merge requests found
Pipeline #128483 failed
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment