Meson pass the argument without quotes and the script accept only $1.
Just omit the argument to make script read the tests list from file.

Daniel Landau authored 8 years ago and Alexander Akulich committed 4 years ago

Never strip out modechars unless we are explicitly trying to parse
a nickname with modechars, i.e., atom 'C'

Daniel Landau authored 8 years ago and Alexander Akulich committed 4 years ago

According to RFC2811 (https://tools.ietf.org/html/rfc2811#section-3.2)
channel names can start with a bang. Without this check the initial bang
gets stripped out and Telepathy tries to ensure as a channel without the
prefix. That obviously fails, leading to the messages from that channel
arriving as "private" messages.

David Heidelberg authored 5 years ago and Alexander Akulich committed 4 years ago

Fixes:
In function 'strncpy',
    inlined from 'idle_server_connection_send_async' at idle-server-connection.c:593:2:
/usr/include/bits/string_fortified.h:106:10: error: '__builtin_strncpy' specified bound 512 equals destination size [-Werror=stringop-truncation]
  106 |   return __builtin___strncpy_chk (__dest, __src, __len, __bos (__dest));
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors

Signed-off-by: David Heidelberg <david@ixit.cz>

Michael Catanzaro authored 4 years ago and Alexander Akulich committed 4 years ago

IRC messages are delimited by CRLF. When the string passed to
idle_parser_receive() doesn't end in \r or \n, the remaining parts get
stashed away to be used to form a message on the next call to
idle_parser_receive(). But telepathy-idle improperly assumes that the
next call to idle_parser_receive() will definitely contain \r or \n,
i.e. it assumes that an IRC message cannot be split between three calls
to idle_parser_receive(). That assumption is wrong.

Fixes polari#147

Michael Catanzaro authored 4 years ago and Alexander Akulich committed 4 years ago

Hello from 2020!

Fixes taken from Bastien's Fedora patches. Thanks Bastien!

Guillaume Desmottes authored 11 years ago and Alexander Akulich committed 5 years ago

Recent GLib raises a critical when trying to remove an invalid source.

(cherry picked from commit 12211654)

I asked one of the polari devs and was told that yes it is ok to set
the timer id to zero in the timer function.

With this patch make check works without changing any of the expected
test results and without any coredumps

Because stream.nick is Unicode when sendMessage combines the command,
nick, and invalid utf8 python 2.7 ends up converting everything to
Unicode. Since this test deliberately includes invalid Unicode, Python
notices and throws an exception.

In Python 3, network traffic is usually encoded as bytes. So I thought
coercing the nick to bytes would be appropriate, and as bytes can contain
anything including invalid Unicode, Python doesn't throw an exception.

Valid for 10 years

When stripping color codes, we currently remove any sequence of digits
following ^C. As color codes use at most two digits, this means that we
also remove any numbers at the start of the colored text - make sure we
stop doing that and only remove digits that are actually part of a color
code.

https://bugs.freedesktop.org/show_bug.cgi?id=94189

When stripping color codes, we currently remove any sequence of digits
following ^C. As color codes use at most two digits, this means that we
also remove any numbers at the start of the colored text - make sure we
stop doing that and only remove digits that are actually part of a color
code.

https://bugs.freedesktop.org/show_bug.cgi?id=94189

Recent GLib raises a critical when trying to remove an invalid source.

Bug: https://bugs.freedesktop.org/show_bug.cgi?id=25147


Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>

Bug: https://bugs.freedesktop.org/show_bug.cgi?id=25147


Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>

Bug: https://bugs.freedesktop.org/show_bug.cgi?id=25147


Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>

I deliberately picked an example using a non standard IRC command as this
interface is not meant to be used as a substitute for proper Telepathy API.

Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=70434

Not doing so breaks distcheck.

Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=70434

Used to send arbitrary IRC commands to the server.

Bug: https://bugs.freedesktop.org/show_bug.cgi?id=54114


Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>

Bug: https://bugs.freedesktop.org/show_bug.cgi?id=54114


Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>