Skip to content
  • Gert Wollny's avatar
    virgl: Allow RGB32* textures only as buffer objects · 0bde9739
    Gert Wollny authored and Gert Wollny's avatar Gert Wollny committed
    
    
    When requesting a texture of the internal format GL_RGB32F Gallium will
    try to allocate a renderable texture and returns RGBA32F or RGBX32F, but
    when one requests GL_RGB32I or GL_RGB32UI the according 3-component
    texture will be returned. This leads to problems later, when one wants
    to use glCopyImageSubData to copy data between these textures that should
    be compatible, but given the way virgl and Gallium  handle this the latter
    fails with an assertion, because the per-texel bit size is different.
    
    By allowing the GL_RGB32* only for texture buffers these problems are avoided
    without losing the ARB_tbo_rgb32 extension (thanks Ilia Mirkin).
    
    v2: Correct spelling (Gurchetan Singh)
    
    Signed-off-by: default avatarGert Wollny <gert.wollny@collabora.com>
    Reviewed-by: default avatarGurchetan Singh <gurchetansingh@chromium.org>
    0bde9739