-
- Downloads
drm/amd/display: Fix 4to1 MPC black screen with DPP RCO
commit bf224e00 upstream. [Why] DPP Root clock optimization when combined with 4to1 MPC combine results in the screen turning black. This is because the DPPCLK is stopped during the middle of an optimize_bandwidth sequence during commit_minimal_transition without going through plane power down/power up. [How] The intent of a 0Hz DPP clock through update_clocks is to disable the DTO. This differs from the behavior of stopping the DPPCLK entirely (utilizing a 0Hz clock on some ASIC) so it's better to move this logic to reside next to plane power up/power down where we gate the HUBP/DPP DOMAIN. The new sequence should be: Power down: PG enabled -> RCO on Power up: RCO off -> PG disabled Rename power_on_plane to power_on_plane_resources to reflect the actual operation that's occurring. Cc: stable@vger.kernel.org Cc: Mario Limonciello <mario.limonciello@amd.com> Reviewed-by:Jun Lei <Jun.Lei@amd.com> Acked-by:
Qingqing Zhuo <qingqing.zhuo@amd.com> Signed-off-by:
Nicholas Kazlauskas <nicholas.kazlauskas@amd.com> Tested-by:
Daniel Wheeler <daniel.wheeler@amd.com> Signed-off-by:
Alex Deucher <alexander.deucher@amd.com> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Showing
- drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c 10 additions, 2 deletionsdrivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c
- drivers/gpu/drm/amd/display/dc/dcn20/dcn20_hwseq.c 6 additions, 2 deletionsdrivers/gpu/drm/amd/display/dc/dcn20/dcn20_hwseq.c
- drivers/gpu/drm/amd/display/dc/dcn31/dcn31_dccg.c 2 additions, 11 deletionsdrivers/gpu/drm/amd/display/dc/dcn31/dcn31_dccg.c
- drivers/gpu/drm/amd/display/dc/dcn314/dcn314_dccg.c 23 additions, 0 deletionsdrivers/gpu/drm/amd/display/dc/dcn314/dcn314_dccg.c
- drivers/gpu/drm/amd/display/dc/dcn314/dcn314_hwseq.c 10 additions, 0 deletionsdrivers/gpu/drm/amd/display/dc/dcn314/dcn314_hwseq.c
- drivers/gpu/drm/amd/display/dc/dcn314/dcn314_hwseq.h 2 additions, 0 deletionsdrivers/gpu/drm/amd/display/dc/dcn314/dcn314_hwseq.h
- drivers/gpu/drm/amd/display/dc/dcn314/dcn314_init.c 1 addition, 0 deletionsdrivers/gpu/drm/amd/display/dc/dcn314/dcn314_init.c
- drivers/gpu/drm/amd/display/dc/inc/hw/dccg.h 14 additions, 11 deletionsdrivers/gpu/drm/amd/display/dc/inc/hw/dccg.h
- drivers/gpu/drm/amd/display/dc/inc/hw_sequencer_private.h 4 additions, 0 deletionsdrivers/gpu/drm/amd/display/dc/inc/hw_sequencer_private.h
Loading
Please register or sign in to comment