- Apr 13, 2022
-
-
fossil-db (Sienna Cichlid): Totals from 376 (0.23% of 162293) affected shaders: MaxWaves: 9620 -> 9596 (-0.25%); split: +0.08%, -0.33% Instrs: 207533 -> 203901 (-1.75%); split: -1.76%, +0.01% CodeSize: 1130904 -> 1106420 (-2.16%); split: -2.17%, +0.01% VGPRs: 14016 -> 14120 (+0.74%); split: -0.34%, +1.08% Latency: 2143281 -> 2132212 (-0.52%); split: -0.56%, +0.05% InvThroughput: 389116 -> 387990 (-0.29%); split: -0.34%, +0.05% VClause: 4483 -> 4485 (+0.04%); split: -0.11%, +0.16% SClause: 5780 -> 5778 (-0.03%); split: -0.17%, +0.14% Copies: 15319 -> 15331 (+0.08%); split: -0.53%, +0.61% Branches: 5561 -> 5563 (+0.04%) PreSGPRs: 11776 -> 11775 (-0.01%) PreVGPRs: 11393 -> 11497 (+0.91%); split: -0.13%, +1.04% Signed-off-by: Rhys Perry <pendingchaos02@gmail.com> Reviewed-by: Timur Kristóf <timur.kristof@gmail.com> Part-of: <mesa/mesa!13778>
-
Signed-off-by: Rhys Perry <pendingchaos02@gmail.com> Reviewed-by: Timur Kristóf <timur.kristof@gmail.com> Part-of: <mesa/mesa!13778>
-
Signed-off-by: Rhys Perry <pendingchaos02@gmail.com> Reviewed-by: Timur Kristóf <timur.kristof@gmail.com> Part-of: <mesa/mesa!13778>
-
Signed-off-by: Rhys Perry <pendingchaos02@gmail.com> Reviewed-by: Timur Kristóf <timur.kristof@gmail.com> Part-of: <mesa/mesa!13778>
-
Signed-off-by: Rhys Perry <pendingchaos02@gmail.com> Reviewed-by: Timur Kristóf <timur.kristof@gmail.com> Part-of: <mesa/mesa!13778>
-
Signed-off-by: Rhys Perry <pendingchaos02@gmail.com> Reviewed-by: Timur Kristóf <timur.kristof@gmail.com> Part-of: <mesa/mesa!13778>
-
Signed-off-by: Rhys Perry <pendingchaos02@gmail.com> Reviewed-by: Timur Kristóf <timur.kristof@gmail.com> Part-of: <mesa/mesa!13778>
-
Signed-off-by: Rhys Perry <pendingchaos02@gmail.com> Reviewed-by: Timur Kristóf <timur.kristof@gmail.com> Part-of: <mesa/mesa!13778>
-
We need to wait for cp dma if VK_PIPELINE_STAGE_2_ALL_TRANSFER_BIT or VK_PIPELINE_STAGE_2_ALL_COMMANDS_BIT are set. Closes: #5911 Fixes: 4b9bc479 ("radv: only sync CP DMA for transfer operations or bottom pipe") Signed-off-by: Konstantin Seurer <konstantin.seurer@gmail.com> Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl> Part-of: <mesa/mesa!15933>
-
Reviewed-by: Rhys Perry <pendingchaos02@gmail.com> Part-of: <mesa/mesa!15408>
-
Reviewed-by: Rhys Perry <pendingchaos02@gmail.com> Part-of: <mesa/mesa!15408>
-
Totals from 5 (0.00% of 135048) affected shaders: (GFX9) SGPRs: 208 -> 160 (-23.08%) CodeSize: 2700 -> 2692 (-0.30%) Instrs: 533 -> 531 (-0.38%) Latency: 41688 -> 41680 (-0.02%) Reviewed-by: Rhys Perry <pendingchaos02@gmail.com> Part-of: <mesa/mesa!15408>
-
VOPC_SDWA can also use arbitrary SGPR pairs on GFX9+. Totals from 5607 (4.16% of 134913) affected shaders: (GFX10.3) CodeSize: 42470760 -> 42452988 (-0.04%) Instrs: 7943174 -> 7942883 (-0.00%) Latency: 102887029 -> 102886305 (-0.00%); split: -0.00%, +0.00% InvThroughput: 20454456 -> 20454338 (-0.00%); split: -0.00%, +0.00% Copies: 376818 -> 376865 (+0.01%); split: -0.00%, +0.01% Reviewed-by: Rhys Perry <pendingchaos02@gmail.com> Part-of: <mesa/mesa!15408>
-
instead of using register hints. Totals from 88367 (65.50% of 134913) affected shaders: (GFX10.3) CodeSize: 322492184 -> 322252912 (-0.07%); split: -0.08%, +0.01% Instrs: 60615809 -> 60541260 (-0.12%); split: -0.12%, +0.00% Latency: 557067980 -> 557009210 (-0.01%); split: -0.01%, +0.00% InvThroughput: 109676757 -> 109674804 (-0.00%); split: -0.00%, +0.00% SClause: 1939703 -> 1939924 (+0.01%); split: -0.01%, +0.02% Copies: 4557567 -> 44875308 (-1.54%); split: -1.54%, +0.00% Branches: 1941123 -> 1937453 (-0.19%) Reviewed-by: Rhys Perry <pendingchaos02@gmail.com> Part-of: <mesa/mesa!15408>
-
A future commit will make VCC register assignment independent from register hints. Up to GFX9, VCC can alternatively be used as regular SGPR, so prevent overlap. Reviewed-by: Rhys Perry <pendingchaos02@gmail.com> Part-of: <mesa/mesa!15408>
-
v2: More replacements Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com> Reviewed-by: Jason Ekstrand <jason.ekstrand@collabora.com> Reviewed-by: Tapani Pälli <tapani.palli@intel.com> (v1) Part-of: <mesa/mesa!15920>
-
If we made a copy deref, then we need to do dead-write elimination for the pervious writes or we'll just emit the same copy deref again next time around. And, at the end of the opt loop, we need to lower copy derefs because later passes (locals_to_regs, notably) depend on it. Fixes infinite opt loop on fs-function-inout-array with virgl on NTT. Reviewed-by: Gert Wollny <gert.wollny@collabora.com> Part-of: <mesa/mesa!15899>
-
rusticl (and clover) would like to get a graceful fail here so they can fall back to a shadow copy instead of us asserting. We also start rejecting arrayed surface because isl doesn't allow selecting a QPitch yet. Even if it did, QPitch is horribly restrictive, even for linear surfaces, that it likely wouldn't be that useful. Fixes: e81f3edf ("iris: Allow userptr on 1D and 2D images") Reviewed-by: Kenneth Graunke <kenneth@whitecape.org> Part-of: <mesa/mesa!15903>
-
this otherwise breaks kopper fixes #6294 Reviewed-by: Erik Faye-Lund <erik.faye-lund@collabora.com> Part-of: <mesa/mesa!15928>
-
A custom branch of `deqp` is used to have proper results when crashing. See: https://github.com/KhronosGroup/VK-GL-CTS/issues/311 A custom branch of `deqp-runner` with Windows support is also used until the changes are merged into the main repository. The `api`, `info`, `draw`, `query-pool` and `memory` test cases are executed for now. Signed-off-by: Louis-Francis Ratté-Boulianne <lfrb@collabora.com> Acked-by: Boris Brezillon <boris.brezillon@collabora.com> Part-of: <mesa/mesa!15742>
-
Signed-off-by: Louis-Francis Ratté-Boulianne <lfrb@collabora.com> Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com> Reviewed-by: Erik Faye-Lund <erik.faye-lund@collabora.com> Part-of: <mesa/mesa!15742>
-
Signed-off-by: Karmjit Mahil <Karmjit.Mahil@imgtec.com> Reviewed-by: Frank Binns <frank.binns@imgtec.com> Part-of: <mesa/mesa!15880>
-
Signed-off-by: Karmjit Mahil <Karmjit.Mahil@imgtec.com> Reviewed-by: Frank Binns <frank.binns@imgtec.com> Part-of: <mesa/mesa!15880>
-
Signed-off-by: Karmjit Mahil <Karmjit.Mahil@imgtec.com> Reviewed-by: Frank Binns <frank.binns@imgtec.com> Part-of: <mesa/mesa!15880>
-
This is trivial thanks to the emulated timelines provided in common code. "Real" timeline semaphores which can be shared across processes will require kernel support. Reviewed-by: Iago Toral Quiroga <itoral@igalia.com> Part-of: <mesa/mesa!15704>
-
vulkaninfo is the same before and after. Reviewed-by: Iago Toral Quiroga <itoral@igalia.com> Part-of: <mesa/mesa!15704>
-
vulkaninfo is the same before and after. Reviewed-by: Iago Toral Quiroga <itoral@igalia.com> Part-of: <mesa/mesa!15704>
-
Reviewed-by: Iago Toral Quiroga <itoral@igalia.com> Part-of: <mesa/mesa!15704>
-
Even if we're the first job on some queue, there may be no wait semaphores but we still need to ensure things happen in-order. (See the "Implicit Synchronization Guarantees" section of the Vulkan spec.) The client can submit back-to-back command buffers with no semaphores between them and it needs to adt the same as if there were a semaphore. If job->serialize is set because of a barrier or something, we still need to synchronize across HW queues by waiting on last_job_syncs. Reviewed-by: Iago Toral Quiroga <itoral@igalia.com> Part-of: <mesa/mesa!15704>
-
In order to properly wait for a query to be complete, we need to first wait for the end query job to flush through on the queue. Since query end is always handled on the CPU, we can do this with a condition variable. The 2s timeout is taken from ANV. Reviewed-by: Alejandro Piñeiro <apinheiro@igalia.com> Reviewed-by: Iago Toral Quiroga <itoral@igalia.com> Part-of: <mesa/mesa!15704>
-
Reviewed-by: Alejandro Piñeiro <apinheiro@igalia.com> Reviewed-by: Iago Toral Quiroga <itoral@igalia.com> Part-of: <mesa/mesa!15704>
-
Vulkan requires that, once the device has been lost, you keep returning VK_ERROR_DEVICE_LOST. We've got tracking for this in common code; it just needs to be wired up. Reviewed-by: Alejandro Piñeiro <apinheiro@igalia.com> Reviewed-by: Iago Toral Quiroga <itoral@igalia.com> Part-of: <mesa/mesa!15704>
-
Reviewed-by: Alejandro Piñeiro <apinheiro@igalia.com> Reviewed-by: Iago Toral Quiroga <itoral@igalia.com> Part-of: <mesa/mesa!15704>
-
This only works because c11/threads.h is typedeffing the c11 stuff to ptrheads. Reviewed-by: Alejandro Piñeiro <apinheiro@igalia.com> Reviewed-by: Iago Toral Quiroga <itoral@igalia.com> Part-of: <mesa/mesa!15704>
-
Instead of having the CPU job execute the CSD job, put both jobs on the list with the CPU job first which modifies the GPU job which gets kicked off next. This gives the queue code more visibility into what types of jobs are actually in the list. In particular, if an indirect compute job is the last job in a batch buffer, it currently appears as if the batch ends with CPU work which isn't true because it kicks off GPU work. In that case, the last job on the list is now a GPU job, which better matches reality. Reviewed-by: Iago Toral Quiroga <itoral@igalia.com> Part-of: <mesa/mesa!15704>
-
vk_device_init() will do this. Reviewed-by: Alejandro Piñeiro <apinheiro@igalia.com> Reviewed-by: Iago Toral Quiroga <itoral@igalia.com> Part-of: <mesa/mesa!15704>
-
The v3dv kernel driver doesn't support timelines yet but we want threaded submit and that requires WAIT_PENDING. Fortunately, it should never sit in this loop for long in practice. The primary use-case is sorting out dependencies and these checks will always trivially succeed for non-shared semaphores because v3dv only has a single queue. Acked-by: Alejandro Piñeiro <apinheiro@igalia.com> Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com> Part-of: <mesa/mesa!15704>
-
No fossil-db changes. Signed-off-by: Rhys Perry <pendingchaos02@gmail.com> Reviewed-by: Timur Kristóf <timur.kristof@gmail.com> Part-of: <mesa/mesa!14124>
-
fossil-db (Sienna Cichlid): Totals from 400 (0.30% of 134621) affected shaders: VGPRs: 18696 -> 18688 (-0.04%) CodeSize: 2031348 -> 1946640 (-4.17%) Instrs: 374703 -> 360226 (-3.86%) Latency: 4200727 -> 4108628 (-2.19%); split: -2.20%, +0.01% InvThroughput: 1059935 -> 1029441 (-2.88%); split: -2.88%, +0.00% VClause: 5777 -> 5771 (-0.10%) SClause: 11890 -> 10891 (-8.40%); split: -8.57%, +0.17% Copies: 34035 -> 33259 (-2.28%); split: -2.98%, +0.70% Branches: 11108 -> 11100 (-0.07%); split: -0.08%, +0.01% PreSGPRs: 15999 -> 15942 (-0.36%); split: -0.44%, +0.08% PreVGPRs: 16994 -> 16970 (-0.14%) fossil-db (Polaris10): Totals from 400 (0.29% of 135668) affected shaders: SGPRs: 23799 -> 22919 (-3.70%); split: -4.30%, +0.61% VGPRs: 18480 -> 18472 (-0.04%) CodeSize: 2090316 -> 2041592 (-2.33%) Instrs: 395461 -> 385747 (-2.46%); split: -2.46%, +0.00% Latency: 5045768 -> 5020196 (-0.51%); split: -0.53%, +0.02% InvThroughput: 2694320 -> 2689886 (-0.16%); split: -0.23%, +0.07% VClause: 5982 -> 5968 (-0.23%) SClause: 12064 -> 10823 (-10.29%); split: -10.33%, +0.04% Copies: 48233 -> 48322 (+0.18%); split: -0.47%, +0.65% PreSGPRs: 16409 -> 16358 (-0.31%); split: -0.39%, +0.08% fossil-db (Pitcairn): Totals from 400 (0.29% of 135668) affected shaders: SGPRs: 22431 -> 22215 (-0.96%); split: -2.60%, +1.64% VGPRs: 18776 -> 18560 (-1.15%); split: -1.21%, +0.06% CodeSize: 2104440 -> 2017708 (-4.12%) MaxWaves: 2363 -> 2367 (+0.17%) Instrs: 413099 -> 397446 (-3.79%) Latency: 5507707 -> 5450251 (-1.04%); split: -1.12%, +0.07% InvThroughput: 2838867 -> 2786903 (-1.83%); split: -1.83%, +0.00% VClause: 10334 -> 10097 (-2.29%) SClause: 12346 -> 11005 (-10.86%); split: -10.89%, +0.02% Copies: 54034 -> 52065 (-3.64%); split: -3.99%, +0.35% PreSGPRs: 17916 -> 17857 (-0.33%); split: -0.40%, +0.07% PreVGPRs: 16917 -> 16893 (-0.14%) Signed-off-by: Rhys Perry <pendingchaos02@gmail.com> Reviewed-by: Timur Kristóf <timur.kristof@gmail.com> Part-of: <mesa/mesa!14124>
-
The callback now supports this. This shouldn't have any effect yet except on GFX6 with 12 byte loads. fossil-db (Pitcairn): Totals from 246 (0.18% of 135668) affected shaders: VGPRs: 14684 -> 14768 (+0.57%); split: -0.44%, +1.01% CodeSize: 1765792 -> 1738040 (-1.57%) Instrs: 344605 -> 340055 (-1.32%) Latency: 4892904 -> 4861942 (-0.63%) InvThroughput: 2479599 -> 2446070 (-1.35%) VClause: 8782 -> 8735 (-0.54%) SClause: 9854 -> 9853 (-0.01%) Copies: 47327 -> 45401 (-4.07%); split: -4.08%, +0.01% Signed-off-by: Rhys Perry <pendingchaos02@gmail.com> Reviewed-by: Timur Kristóf <timur.kristof@gmail.com> Part-of: <mesa/mesa!14124>
-