Skip to content
Snippets Groups Projects
  1. Jan 29, 2024
  2. Jan 26, 2024
    • Aleksander Morgado's avatar
      broadband-modem-qmi: refactor power update into a state machine · e6ae6365
      Aleksander Morgado authored
      The logic implementing the operating mode update is composed of
      multiple steps, some of which need to be skipped depending on previous
      state.
      
      Switch the logic to a state machine with a clear step enumeration
      indicating the order of the updates.
      e6ae6365
    • Aleksander Morgado's avatar
      broadband-modem-qmi: don't complete the power update before receiving the response · cddf31bf
      Aleksander Morgado authored
      When relying on the power update indications, we were completing the
      operation as soon as the indication was received, regardless of
      whether the request response was received or not.
      
      Avoid doing that, and instead complete the operation only when both
      indication and the response are received. This avoid misalignment in
      the operation completion if a new one is scheduled just after the one
      we have completed.
      cddf31bf
    • Aleksander Morgado's avatar
    • Aleksander Morgado's avatar
      broadband-modem-qmi: keep power operation ongoing until fully finished · 80db88da
      Aleksander Morgado authored
      The GTask stored in the private modem struct indicates whether a power
      update operation is ongoing. We should keep this task stored always
      until just before completing the GTask.
      
      We also make sure that any additional step (e.g. disabling DMS event
      report indications) is included in the power update operation, so that
      they are correctly synchronized also in the modem.
      
      This fix should solve a crash triggered by a DMS event report
      indication being received while setting up the next power update
      operation.
      
        0x0000007aa67de878 (libc.so.6 + 0x0007e878)     pthread_key_delete
        0x0000007aa6799d28 (libc.so.6 + 0x00039d28)     gsignal
        0x0000007aa6786e2c (libc.so.6 + 0x00026e2c)     abort
        0x0000007aa6feb188 (libglib-2.0.so.0 - gtestutils.c: 3256)      g_assertion_message
        0x0000007aa6feb1f8 (libglib-2.0.so.0 - gtestutils.c: 3282)      g_assertion_message_expr
        0x0000005a58199b7c (ModemManager - mm-broadband-modem-qmi.c: 1926)      dms_set_event_report_operating_mode_activate_ready
        0x0000007aa6e4b7a0 (libgio-2.0.so.0 - gtask.c: 1232)    g_task_return_now
        0x0000007aa6e4a6b0 (libgio-2.0.so.0 - gtask.c: 1301)    g_task_return
        0x0000007aa6b58400 (libqmi-glib.so.5 - qmi-dms.c: 32600)        set_event_report_ready
        0x0000007aa6e3642c (libgio-2.0.so.0 - gsimpleasyncresult.c: 804)        g_simple_async_result_complete
        0x0000007aa6e36538 (libgio-2.0.so.0 - gsimpleasyncresult.c: 816)        complete_in_idle_cb
        0x0000007aa6fc6390 (libglib-2.0.so.0 - gmain.c: 3444)   g_main_context_dispatch
        0x0000007aa6fc66c4 (libglib-2.0.so.0 - gmain.c: 4238)   g_main_context_iterate
        0x0000007aa6fc6a34 (libglib-2.0.so.0 - gmain.c: 4438)   g_main_loop_run
        0x0000005a58119274 (ModemManager - main.c: 221) main
        0x0000007aa67870f8 (libc.so.6 + 0x000270f8)     __libc_init_first
        0x0000007aa67871c8 (libc.so.6 + 0x000271c8)     __libc_start_main
        0x0000005a58118aec (ModemManager + 0x000a8aec)  _start
      80db88da
  3. Jan 25, 2024
    • Madhavadas Pottekkat's avatar
      bearer-mbim: When an IP type is unspecified in the profile, default to IPv4v6 (dual-stack) · 1655d0e0
      Madhavadas Pottekkat authored
      To address limitations in reading IP_TYPE information (in some cases) for profile requests,
      default to IPv4v6 (dual-stack) for profile requests and IPv4 only for user requests (to ensure backward compatibility)
      if nothing specific is requested. This ensures network compatibility across IPv4 and IPv6 networks,
      preventing potential connectivity issues in IPv6 environments.
      1655d0e0
    • Aleksander Morgado's avatar
      iface-modem: allow low-power request while enabled · e8f1edc5
      Aleksander Morgado authored and Aleksander Morgado's avatar Aleksander Morgado committed
      We now enable low-power mode request if we are enabled or even
      connected. In this case, an explicit modem disable operation is run,
      so that we don't end up with an enabled modem in low-power mode.
      
      This new "low-power+disable" single operation makes the two
      "disable+low-power" operation combo that was run until now much much
      quicker, because the modem unregisters from the network and
      disconnects PDNs in the same network interaction.
      e8f1edc5
    • Lukas Vögl's avatar
      cinterion: swap local and dynamic PDP context command · 6f21b1d8
      Lukas Vögl authored and Aleksander Morgado's avatar Aleksander Morgado committed
      
      Signed-off-by: default avatarLukas Voegl <lvoegl@tdt.de>
      6f21b1d8
    • Lukas Vögl's avatar
      cinterion: default to none authentication with no user and password · c4eac364
      Lukas Vögl authored and Aleksander Morgado's avatar Aleksander Morgado committed
      
      Signed-off-by: default avatarLukas Voegl <lvoegl@tdt.de>
      c4eac364
    • Aleksander Morgado's avatar
      build: add maintainers to README copyright · e43d9ea8
      Aleksander Morgado authored and Aleksander Morgado's avatar Aleksander Morgado committed
      e43d9ea8
    • Yegor Yefremov's avatar
      build: convert README to markdown · 18144e73
      Yegor Yefremov authored and Aleksander Morgado's avatar Aleksander Morgado committed
      Also add SPDX license identifier and a copyright notice.
      18144e73
    • Lukas Vögl's avatar
      cinterion: change secondary port to ppp on PLS8 · 030ec7c5
      Lukas Vögl authored and Aleksander Morgado's avatar Aleksander Morgado committed
      
      Signed-off-by: default avatarLukas Voegl <lvoegl@tdt.de>
      030ec7c5
    • Aleksander Morgado's avatar
      port-qmi: allow preallocated links when using rmnet multiplexing · 7ad85d2b
      Aleksander Morgado authored and Aleksander Morgado's avatar Aleksander Morgado committed
      A new ID_MM_QMI_PREALLOCATED_LINKS udev tag, set in the NET port of
      the device, allows configuring the amount of preallocated multiplexed
      links that need to be created upon the first connection attempt,
      regardless of the multiplexing setup method used.
      
      If not specified by the user, 4 preallocated links are created when
      using the qmi_wwan multiplexing procedure, and none for rmnet.
      
      Previously, using preallocated links was exclusive used with the
      qmi_wwan multiplexing procedure. Using preallocated links may be
      useful if you want to maintain the same links across multiple
      connection and disconnection loops, e.g. if running a tcpdump on a
      given link interface capturing all traffic (not using preallocated
      links in this case would be problematic as tcpdump cannot be requested
      to run on net interfaces that don't exist yet).
      7ad85d2b
    • Aleksander Morgado's avatar
      910e450e
    • Aleksander Morgado's avatar
      port-qmi: fix double free when WDA Set Data Format fails · 99f52026
      Aleksander Morgado authored and Aleksander Morgado's avatar Aleksander Morgado committed
        Thread 0(id: 4915) CRASHED [ SIGABRT@0x0000000000000000 ]
        0x00007b0f6732fa3f (libc.so.6 - pthread_kill.c: 44) __pthread_kill_implementation
        0x00007b0f672e4c6c (libc.so.6 - raise.c: 26) raise
        0x00007b0f672d0462 (libc.so.6 - abort.c: 79) abort
        0x00007b0f67323347 (libc.so.6 - libc_fatal.c: 155) __libc_message
        0x00007b0f67339929 (libc.so.6 - malloc.c: 5664) malloc_printerr
        0x00007b0f6733b5cb (libc.so.6 - malloc.c: 4439) _int_free
        0x00007b0f6733e279 (libc.so.6 - malloc.c: 3391) __libc_free
        0x00007b0f67abcabe (libglib-2.0.so.0 - gerror.c: 856) g_error_free
        0x000059fc4262623e (ModemManager - glib-autocleanups.h: 54) glib_autoptr_clear_GError
        0x000059fc4262623e (ModemManager - glib-autocleanups.h: 54) glib_autoptr_cleanup_GError
        0x000059fc4262623e (ModemManager - mm-port-qmi.c: 1501) set_data_format_ready
        0x00007b0f67985e57 (libgio-2.0.so.0 - gtask.c: 1309) g_task_return_now
        0x00007b0f67984e21 (libgio-2.0.so.0 - gtask.c: 1378) g_task_return
        0x00007b0f677f7107 (libqmi-glib.so.5 - qmi-wda.c: 4761) set_data_format_ready
        0x00007b0f67972329 (libgio-2.0.so.0 - gsimpleasyncresult.c: 804) g_simple_async_result_complete
        0x00007b0f6797240a (libgio-2.0.so.0 - gsimpleasyncresult.c: 816) complete_in_idle_cb
        0x00007b0f67ad17a4 (libglib-2.0.so.0 - gmain.c: 3460) g_main_dispatch
        0x00007b0f67ad17a4 (libglib-2.0.so.0 - gmain.c: 4200) g_main_context_dispatch
        0x00007b0f67ad1ac3 (libglib-2.0.so.0 - gmain.c: 4276) g_main_context_iterate
        0x00007b0f67ad1d41 (libglib-2.0.so.0 - gmain.c: 4479) g_main_loop_run
        0x000059fc425657df (ModemManager - main.c: 236) main
        0x00007b0f672d06c5 (libc.so.6 - libc_start_call_main.h: 58) __libc_start_call_main
        0x00007b0f672d0781 (libc.so.6 - libc-start.c: 389) __libc_start_main_impl
        0x000059fc42565130 (ModemManager) _start
        0x00007fffdea098c7
      99f52026
  4. Jan 19, 2024
  5. Jan 15, 2024
  6. Jan 11, 2024
  7. Jan 10, 2024
  8. Dec 18, 2023
  9. Dec 13, 2023
  10. Dec 12, 2023
  11. Dec 11, 2023
    • Raphaël Jakse's avatar
      iface-location: allow enabling without SIM · 63dd4ad2
      Raphaël Jakse authored and Aleksander Morgado's avatar Aleksander Morgado committed
      When the modem is in a failed state because of a SIM-related error,
      like a missing SIM, or if the modem is SIM-locked, allow the
      Location interface to initialize and be enabled anyway.
      
      This allows someone without a SIM to use the GPS, which does not
      particularly require a phone subscription. It also allows
      someone with a SIM to use the GPS even if the SIM is still
      locked.
      
      This patch was reworked, while keeping the original idea, by:
      Aleksander Morgado <aleksander@aleksander.es>
      
      Fixes #183
      63dd4ad2
  12. Dec 01, 2023
Loading