Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Acked-by: Victor Toso <victortoso@redhat.com>

In the error path, 'new_apdu->a_data' is not freed.
This can be triggered by the guest continuely.

Signed-off-by: Li Qiang <liqiang6-s@360.cn>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>

During our testing of a new CAC driver in OpenSC, with this library, we
encountered a problem with |libcacard| failing and the driver returning
only a fraction of the requested objects.

The problem is that the Emulator wants to return the data (properly
signalized by 61 (RESPONSE BYTES) in SW1), but this is ignored for some
reason in some of our calls from OpenSC. The Emulator should not fail
hard for the next independent request, rather silently drop the buffer
and serve the ongoing APDU request (I would left for consideration to
somehow log such problem).

Patch was successfully tested on Fedora 24 host and solves our problem
(though we worked around the problem already in the driver too).

Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>

scan-build gives a false-positive error because it gets confused that
optarg may be NULL. Help him by adding an assert.

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reported-by: Miroslav Rezanina <mrezanin@redhat.com>

The db argument must end with " or \n.

Found thanks to clang scan-build.

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reported-by: Miroslav Rezanina <mrezanin@redhat.com>

qemu.git uses -Werror by default, and this is problematic as 2.5.0
doesn't use libcacard.h and it breaks some developpers setup.

Remove the warning and release 2.5.2.

This change can be reverted in a near future (after 2.5.0 release and
a qemu patch is merged?)

Signed-off-by: Marc-André Lureau <marcandre.lureau@gmail.com>

Signed-off-by: Marc-André Lureau <marcandre.lureau@gmail.com>

Signed-off-by: Marc-André Lureau <marcandre.lureau@gmail.com>

Signed-off-by: Marc-André Lureau <marcandre.lureau@gmail.com>

Show no if PCSC is disabled

Signed-off-by: Marc-André Lureau <marcandre.lureau@gmail.com>

If the compiler in use is a C++ compiler, adds extern "C" around the
header.

Signed-off-by: Marc-André Lureau <marcandre.lureau@gmail.com>

Only libcacard.h should be included directly.

Signed-off-by: Marc-André Lureau <marcandre.lureau@gmail.com>

vscard_common.h uses glib G_BYTE_ORDER macros. Include glib.h in the
file, and thus move glib-2.0 as a Require package.

Signed-off-by: Marc-André Lureau <marcandre.lureau@gmail.com>

This gets it into the .gitignore, and gets it cleaned
by a maintainer-clean.

Fixes 'make check' on Debian.

Without it, running autoreconf -fi from a tarball is going to spew a lot
of warnings about this missing file, and afterwards, ./configure will
generate version-less .pc files.

This test was not automated and is now redundant with make check tests

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>

So the whole project use the same log domain.

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>

A top-level header file is often easier to deal with for programs

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>

It was not in the exported symbols, so it shouldn't hurt to remove it now.

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>

'smatch' complains about two bugs and one style issue in card_7816.c:

libcacard/card_7816.c:273 vcard_apdu_set_length() warn: should this be a bitwise op?
libcacard/card_7816.c:295 vcard_apdu_set_length() warn: should this be a bitwise op?
libcacard/card_7816.c:661 vcard7816_vm_process_apdu() warn: inconsistent indenting

... and indeed, the code seems to be wrong here. Let's fix this
by using a bitwise OR instead of logical OR and by indenting
the code with the right level.

Signed-off-by: Thomas Huth <thuth@linux.vnet.ibm.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>

USE_PASSTHRU was not implemented and -p was useless.

That option can be achieved using -e "use_hw=yes hw_type=passthru"

Signed-off-by: Jeremy White <jwhite@codeweavers.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>

Enable support for passthru (e.g. direct to pcsc) smart cards in the
emul_options entry point in libcacard.

Signed-off-by: Jeremy White <jwhite@codeweavers.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>

This uses libpcsclite to provide direct communication with a smartcard.

Signed-off-by: Jeremy White <jwhite@codeweavers.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>

Also add an alias of 'nssemul' for the default card
of hw=yes hw_type=cac.

This allows the spice-gtk client to take a more human
friendly set of arguments and relay them through to this code.

Signed-off-by: Jeremy White <jwhite@codeweavers.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>

As far as I can tell, the vreader_remove_reader function is not presently in
use anywhere; I have an upcoming patch set that uses it.

Signed-off-by: Jeremy White <jwhite@codeweavers.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>

(alternatively, we could simply require this to be installed, but it's
very recent and the autofoo error is unfriendly)

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>

Reported by Michael Tokarev.

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>

Otherwise the following errors can be faced:
src/vscclient-vscclient.o: In function `send_msg':
/home/ffidenci/src/upstream/libcacard/src/vscclient.c:122: undefined
reference to `_imp__htonl@4'
/home/ffidenci/src/upstream/libcacard/src/vscclient.c:124: undefined
reference to `_imp__htonl@4'
src/vscclient-vscclient.o: In function `on_host_init':
/home/ffidenci/src/upstream/libcacard/src/vscclient.c:260: undefined
reference to `_imp__ntohl@4'
/home/ffidenci/src/upstream/libcacard/src/vscclient.c:273: undefined
reference to `_imp__ntohl@4'
src/vscclient-vscclient.o: In function `do_socket_read':
/home/ffidenci/src/upstream/libcacard/src/vscclient.c:332: undefined
reference to `_imp__ntohl@4'
/home/ffidenci/src/upstream/libcacard/src/vscclient.c:333: undefined
reference to `_imp__ntohl@4'
/home/ffidenci/src/upstream/libcacard/src/vscclient.c:334: undefined
reference to `_imp__ntohl@4'
src/vscclient-vscclient.o: In function `connect_to_qemu':
/home/ffidenci/src/upstream/libcacard/src/vscclient.c:615: undefined
reference to `_imp__socket@12'
/home/ffidenci/src/upstream/libcacard/src/vscclient.c:628: undefined
reference to `_imp__getaddrinfo@16'
/home/ffidenci/src/upstream/libcacard/src/vscclient.c:636: undefined
reference to `_imp__connect@12'
/home/ffidenci/src/upstream/libcacard/src/vscclient.c:645: undefined
reference to `_imp__freeaddrinfo@4'
/home/ffidenci/src/upstream/libcacard/src/vscclient.c:650: undefined
reference to `_imp__freeaddrinfo@4'
/home/ffidenci/src/upstream/libcacard/src/vscclient.c:652: undefined
reference to `_imp__closesocket@4'
src/vscclient-vscclient.o: In function `main':
/home/ffidenci/src/upstream/libcacard/src/vscclient.c:676: undefined
reference to `_imp__WSAStartup@8'
/home/ffidenci/src/upstream/libcacard/src/vscclient.c:677: undefined
reference to `_imp__WSAGetLastError@0'
/home/ffidenci/src/upstream/libcacard/src/vscclient.c:778: undefined
reference to `_imp__htonl@4'
/home/ffidenci/src/upstream/libcacard/src/vscclient.c:791: undefined
reference to `_imp__closesocket@4'
collect2: error: ld returned 1 exit status
Makefile:656: recipe for target 'vscclient.exe' failed
make[2]: *** [vscclient.exe] Error 1
make[2]: Leaving directory '/home/ffidenci/src/upstream/libcacard'
Makefile:774: recipe for target 'all-recursive' failed
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory '/home/ffidenci/src/upstream/libcacard'
Makefile:495: recipe for target 'all' failed
make: *** [all] Error 2

This header has the definition of getaddrinfo, according to:
https://msdn.microsoft.com/en-us/library/windows/desktop/ms738520(v=vs.85).aspx

Otherwise the following problem can be faced:
src/vscclient.c: In function 'connect_to_qemu':
src/vscclient.c:642:16: error: unknown conversion type character 'z' in format [-Werror=format=]
         printf("Connected (sizeof Header=%zd)!\n", sizeof(VSCMsgHeader));
                         ^
src/vscclient.c:642:16: error: too many arguments for format [-Werror=format-extra-args]

Without removing cac_is_cac_card the following error can be faced:

Cannot export cac_is_cac_card: symbol not defined
collect2: error: ld returned 1 exit status

Found a not so old QEMU thread about this:
https://www.mail-archive.com/qemu-devel%40nongnu.org/msg291698.html

vscclient needs gthread-2.0, and fails to link on rhel6 without it.

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>