Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • Q qxl-wddm-dod
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 20
    • Issues 20
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 1
    • Merge requests 1
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar

Due to an influx of spam, we have had to impose restrictions on new accounts. Please see this wiki page for instructions on how to get full permissions. Sorry for the inconvenience.

Update #1:

Due to abusive users subverting our CI facilities to mine cryptocurrency, breaking out of the container sandbox in the process, we have been forced to take actions to limit the usage of the public runners to official projects only.

The policy will be enforced on 2023-03-23 (or before if we detect abuses).

Please see this issue for more context and to see if and how you are impacted.

  • spice
  • win32
  • qxl-wddm-dod
  • Merge requests
  • !1

Fix pointer position handling

  • Review changes

  • Download
  • Email patches
  • Plain diff
Open Steve Hart requested to merge stevehartdata/qxl-wddm-dod:master into master Dec 24, 2021
  • Overview 1
  • Commits 1
  • Pipelines 0
  • Changes 2

This change fixes the handling of the pointer position coordinates for pointers whose hotspots are not at the upper left-hand corner. Before this change, any pointer whose hotspot was not in the upper left-hand corner was displayed in the wrong position by spice-gtk when the guest was using this driver with the QEMU QXL device. The issue was especially obvious in applications like Microsoft Paint, which uses a cross-hair pointer whose center is supposed to be displayed at the cursor position.

I'm a little bit surprised that nobody else has reported this issue, but I've been using my fix for two months, and all the cursors have been in the correct position with the updated driver. This is my first foray into the SPICE/QXL code and Windows device drivers, so please let me know if I'm mistaken about any of this.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: master