Prefer g_strerror() to strerror()

See merge request !146

vmstate.h: Prefer __typeof__ vice typeof

See merge request !145

Use g_strerror() for better cross platform compatibility: glib handles
the Windows "deprecation" (i.e., use strerror_s instead of strerror),
fewer warnings at compile time.

Clang masquerading as gcc on macOS (i.e., "gcc") borks on typeof(), but
happily accepts __typeof__().

N.B., __typeof__ has been accepted by GCC and Clang for a long time, and
recently MS decided to support it as well.

cksum: NetBSD-adapted cksum()

See merge request !144

B. Scott Michel authored Nov 05, 2024 and Samuel Thibault committed Nov 14, 2024

Update cksum() to use more recent NetBSD-based checksum implementation.
The updated implementation includes both a 64-bit and 32-bit (the
default) implementations. The 64-bit implementation has a longer stride
length, which may be beneficial to overall performance.

Update the return types for cksum() and ip6_cksum() to uint16_t, which
is what the checksum algorithm computes.

arp_table: use size_t to index arrays.

See merge request !142

Debugging API

See merge request !139

slirp_(un)register_poll_socket: void returning value

See merge request !141

void functions don't return values.

as they were before 72f85005 ("socket abstraction: slirp_os_socket"):
that broke the ABI. Better introduce SlirpAddPollCbSocket,
{,un}register_poll_socket that people can use instead, and wrappers for
the old API, for a smooth API/ABI upgrade.

Fixes 72f85005 ("socket abstraction: slirp_os_socket")

Alexander Kuznetsov authored Oct 01, 2024 and Samuel Thibault committed Oct 01, 2024

Found by ALT Linux Team.

Signed-off-by: Alexander Kuznetsov <kuznetsovam@altlinux.org>

Fixes #80

B. Scott Michel authored Sep 16, 2024 and Samuel Thibault committed Sep 26, 2024

Use a typedef to abstract socket identifiers because Windows just has to
be different (SOCKET type.) Moreover, SOCKET on Win64 is 64-bits and
generates copious type slicing warnings.

Other related changes:

- Explicitly cast curtime's assignment to unsigned int to tamp down on
  type slicing warning.

- Ensure that errno.h is always included. Important for Windows, which
  would otherwise #define errno as WSAGetLastError(); errno.h #define-s
  errno as a function, i.e., "*errno()".

- Export slirp_inet_aton() utility function for Win32/64.

- tcpx_listen()
  - WSASetLastError() unnecessary.
  - Use have_valid_socket() to check socket in error cleanup code
    (vs. "s >= 0").

B. Scott Michel authored Sep 24, 2024 and Samuel Thibault committed Sep 26, 2024

Bug fix: tcpx_listen() needs to invoke the socket's register_poll_fd()
callback so that platforms can add the socket to their collection of
sockets-of-interest (primarily Windows, also platforms that use select()
and not poll()).

Same for udpx_listen(). Register the created socket!

For Windows, host forwarding "now works gooder!"

The socket is eventually unregistered via the two use cases in which
tcpx_listen() is used:

- slirp_add_hostfwd, slirp_add_hostxfwd: The corresponding "remove"
  functions (slirp_remove_hostfwd, slirp_remove_hostxfwd) invoke
  unregister_poll_fd().

- TCP emulation (tcp_emu() in tcp_subr.c): All calls to tcp_listen() set
  the SS_FACCEPTONCE flag, making the accept() a one-shot event. By
  carefully examining tcp_subr.c, lines 523-531, one sees that
  tcp_connect() unregisters the one-shot accept().

QED.

bootp: Fill siaddr with tftp addr if supplied as per RFC2131

See merge request !135

Signed-off-by: Arusekk <arek_koz@o2.pl>

windows: allow static linking with LIBSLIRP_STATIC macro

See merge request !134

When the macro is defined it will help to link with libslirp statically.
Otherwise, dllimport attribute is added with function symbols and linker
errors are shown as following for static linking.

undefined reference to `__imp_slirp_input'
undefined reference to `__imp_slirp_cleanup'
undefined reference to `__imp_slirp_remove_hostfwd'
etc.

Otherwise e.g. mold complains that it doesn't find all these slirp_*
symbols.

Fixes #77

Signed-off-by: Samuel Thibault <samuel.thibault@ens-lyon.org>

Fixes #76

Since we increase m->m_len by header_size, we mustn't add header_size
again when copying.

n->m_len also needs to be subtracted header_size, since we advance
n->m_data by header_size.

This only had effect for ipv6 trafic with debug builds