Skip to content
Snippets Groups Projects
Commit c8ee10e2 authored by Marc-André Lureau's avatar Marc-André Lureau
Browse files

tcp_ctl: use slirp_fmt()


Make it safer to OOB (sb_cc must not go out of sb_data), warn on
truncation, abort on error.

Signed-off-by: default avatarMarc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: default avatarSamuel Thibault <samuel.thibault@ens-lyon.org>
Message-Id: <20200127092414.169796-6-marcandre.lureau@redhat.com>
parent 98968c4f
No related branches found
No related tags found
No related merge requests found
......@@ -965,9 +965,8 @@ int tcp_ctl(struct socket *so)
}
}
}
sb->sb_cc =
snprintf(sb->sb_wptr, sb->sb_datalen - (sb->sb_wptr - sb->sb_data),
"Error: No application configured.\r\n");
sb->sb_cc = slirp_fmt(sb->sb_wptr, sb->sb_datalen - (sb->sb_wptr - sb->sb_data),
"Error: No application configured.\r\n");
sb->sb_wptr += sb->sb_cc;
return 0;
}
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment