- May 18, 2012
-
-
Ian Romanick authored
Signed-off-by:
Ian Romanick <ian.d.romanick@intel.com>
-
Ian Romanick authored
Signed-off-by:
Ian Romanick <ian.d.romanick@intel.com>
-
Emma Anholt authored
Otherwise, an incomplete framebuffer could have a NULL _ColorReadBuffer and we'd deref that. Reviewed-by:
Brian Paul <brianp@vmware.com> Reviewed-by:
Kenneth Graunke <kenneth@whitecape.org> Reviewed-by:
Ian Romanick <ian.d.romanick@intel.com> (cherry picked from commit 5a827d9a)
-
Emma Anholt authored
Fixes piglit glsl-1.30/execution/switch/fs-uint. Reviewed-by:
Kenneth Graunke <kenneth@whitecape.org> Reviewed-by:
Ian Romanick <ian.d.romanick@intel.com> (cherry picked from commit 9c4e9ce0)
-
Emma Anholt authored
The comment quotes spec saying that only scalar integers are allowed, but we only checked for integer. Fixes piglit switch-expression-const-ivec2.vert Reviewed-by:
Kenneth Graunke <kenneth@whitecape.org> Reviewed-by:
Ian Romanick <ian.d.romanick@intel.com> (cherry picked from commit bbbc7c7d)
-
Emma Anholt authored
I noticed this while unindenting the code. Reviewed-by:
Kenneth Graunke <kenneth@whitecape.org> Reviewed-by:
Ian Romanick <ian.d.romanick@intel.com> (cherry picked from commit 5d6ea16d)
-
Emma Anholt authored
I managed to completely trash it in 22d81f15. Reviewed-by:
Kenneth Graunke <kenneth@whitecape.org> Reviewed-by:
Ian Romanick <ian.d.romanick@intel.com> (cherry picked from commit 5462f367)
-
Emma Anholt authored
Fixes assertion failure in piglit: vs-mat2-struct-assignment.shader_test vs-mat2-array-assignment.shader_test Reviewed-by:
Kenneth Graunke <kenneth@whitecape.org> Reviewed-by:
Ian Romanick <ian.d.romanick@intel.com> (cherry picked from commit aa02884c)
-
Emma Anholt authored
Fixes piglit GL_ARB_shader_objeccts/getactiveuniform-beginend. Reviewed-by:
Brian Paul <brianp@vmware.com> Reviewed-by:
Kenneth Graunke <kenneth@whitecape.org> Reviewed-by:
Ian Romanick <ian.d.romanick@intel.com> (cherry picked from commit ef691885)
-
Brian Paul authored
When glColorMaterial() is used to latch glColor commands to a material attribute, glMaterial calls to change that material should become no-ops. This failed to work properly when the glMaterial call was inside a display list. This removes the Material function from the vbo_attrib_tmp.h template file. We have separate/different implementations for the "save" and "exec" cases now. NOTE: This is a candidate for the 8.0 branch. (cherry picked from commit 1bc16bf9)
-
Brian Paul authored
_mesa_material_bitmask() will record a GL error and return 0 if face or mode are illegal. Return early in that case. NOTE: This is a candidate for the 8.0 branch. (cherry picked from commit f2724905)
-
Kenneth Graunke authored
We were looping over all the vector components, but only dealing with the first one. This was masked by the fact that constant expression handling on built-ins went through custom code for the lessThan() /function/ rather than the ir_binop_less expression operator. NOTE: This is a candidate for all release branches. Reviewed-by:
Ian Romanick <ian.d.romanick@intel.com> Signed-off-by:
Olivier Galibert <galibert@pobox.com> Signed-off-by:
Kenneth Graunke <kenneth@whitecape.org> (cherry picked from commit f72e9b20)
-
Lina Versace authored
This patch removes ARB_framebuffer_object from the GLES1 and GLES2 extension lists in intel_extensions_es.c. Fixes a crash in the Android browser on Ice Cream Sandwich. The Android browser crashed because it did the following, which is legal in GLES2 but not in ARB_framebuffer_object. glGenFramebuffers(1, &fb); glBindFramebuffer(GL_FRAMEBUFFER, fb); // render render render... glDeleteFramebuffers(1, &fb); // go do other stuff... glBindFramebuffer(GL_FRAMEBUFFER, fb); // This bind unexpectedly failed, and the app panics. The semantics of glBindFramebuffer specified by ARB_framebuffer_object (a desktop GL extension) and GLES2 specs are incompatible. The ideal solution to fix this is to create separate API entry points for glBindFramebuffer, one for GL and the other for GLES2. But, until that work is complete, disabling ARB_framebuffer_object in GLES2 contexts safely fixes the problem. Likewise, the semantics of glBindFramebuffer in ARB_framebuffer_object and of glBindFramebufferOES in OES_framebuffer_object (a GLES1 extension) are incompatible. Even though the functions have different names, the semantic difference still results in a bug because both API calls are implemented by a single function, _mesa_BindFramebufferEXT, which handles the semantic difference incorrectly. Again, disabling ARB_framebuffer_object in GLES1 contexts safely fixes this problem. According to the ARB_framebuffer_object spec, the extension is an amalgamation of EXT_framebuffer_object EXT_framebuffer_blit EXT_packed_depth_stencil EXT_framebuffer_multisample By disabling this extension, however, no functionality is removed from GLES1 and GLES2 contexts because 1) the first three extensions are explicitly enabled in Intel's ES extension lists and 2) no functionality of the last extension is exposed in an ES context. Note: This is a candidate for the 8.0 branch. See-also: http://www.mail-archive.com/mesa-dev@lists.freedesktop.org/msg21006.html CC: Charles Johnson <charles.f.johnson@intel.com> CC: Sean Kelley <sean.v.kelley@intel.com> Reviewed-by:
Ian Romanick <idr@freedesktop.org> Signed-off-by:
Chad Versace <chad.versace@linux.intel.com> (cherry picked from commit 1c0f5d83)
-
Jordan Justen authored
When primitive restart is enabled, and glArrayElement is called with the restart index value, then call glPrimitiveRestartNV. NOTE: This is a candidate for the 8.0 branch. Signed-off-by:
Jordan Justen <jordan.l.justen@intel.com> Reviewed-by:
Brian <Paul<brianp@vmware.com> (cherry picked from commit 5795d3b5)
-
Vinson Lee authored
Fixes Coverity resource leak defect. NOTE: This is a candidate for the 8.0 branch. Signed-off-by:
Vinson Lee <vlee@freedesktop.org> Reviewed-by:
José Fonseca <jfonseca@vmware.com> Reviewed-by:
Kenneth Graunke <kenneth@whitecape.org> (cherry picked from commit b688700e)
-
Han Shen(沈涵) authored
-m32 is not a valid option for ARM. NOTE: This is a candidate for the 8.0 branch. Signed-off-by:
Brian Paul <brianp@vmware.com> (cherry picked from commit b352d676)
-
Kenneth Graunke authored
We already have a meta path below that works just fine; no apparent regressions in oglconform. NOTE: This is a candidate for the 8.0 branch. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=46834 Reviewed-by:
Chad Versace <chad.versace@linux.intel.com> (cherry picked from commit 3cd7bee4)
-
Emma Anholt authored
It seems silly that GL lets you allocate these given that they're framebuffer attachment incomplete, but the webgl conformance tests actually go looking to see if the getters on 0-width/height depth/stencil renderbuffers return good values. By failing out here, they all got smashed to 0, which turned out to be correct for all the getters they tested except for GL_RENDERBUFFER_INTERNAL_FORMAT. Now, by succeeding but not making a miptree, that one also returns the expected value. Acked-by:
Kenneth Graunke <kenneth@whitecape.org> (cherry picked from commit b7406404)
-
Brian Paul authored
When glTexImage or glCopyTexImage is called with internalFormat being a generic compressed format (like GL_COMPRESSED_RGB) we need to do the same error checks as for specific compressed formats. In particular, check if the texture target is compatible with the format. None of the texture compression formats we support so far work with GL_TEXTURE_1D, for example. See also https://bugs.freedesktop.org/show_bug.cgi?id=49124 NOTE: This is a candidate for the 8.0 branch. (cherry picked from commit a36581cc)
-
Brian Paul authored
If the source region for a glCopyPixels is completely outside the source buffer bounds, no-op the copy. Fixes a failed assertion. NOTE: This is a candidate for the 8.0 branch. Reviewed-by:
Jose Fonseca <jfonseca@vmware.com> (cherry picked from commit 99ed0b2f)
-
Vinson Lee authored
Fix uninitialized scalar field defect reported by Coverity. NOTE: This is a candidate for the 8.0 branch. Signed-off-by:
Vinson Lee <vlee@freedesktop.org> Reviewed-by:
Brian Paul <brianp@vmware.com> (cherry picked from commit 10ec1486)
-
Lina Versace authored
I forgot to free the string returned by strdup(). Note: This is a candidate for the stable branches. CC: Johannes Obermayr <johannesobermayr@gmx.de> Reviewed-by:
Ian Romanick <ian.d.romanick@intel.com> Signed-off-by:
Chad Versace <chad.versace@linux.intel.com> (cherry picked from commit 36fef005)
-
Vinson Lee authored
Fixes Coverity resource leak defects. NOTE: This is a candidate for the 8.0 branch. Signed-off-by:
Vinson Lee <vlee@freedesktop.org> Reviewed-by:
Brian Paul <brianp@vmware.com> (cherry picked from commit 431b458f)
-
Vinson Lee authored
Fixes a Coverity resource leak defect. NOTE: This is a candidate for the 8.0 branch. Signed-off-by:
Vinson Lee <vlee@freedesktop.org> Reviewed-by:
Kenneth Graunke <kenneth@whitecape.org> (cherry picked from commit 4123d0b3)
-
Kenneth Graunke authored
According to the BSpec ISA volume's "Accumulator Register" section: "[DevIVB] SIMD16 execution on dwords is not allowed when accumulator is explicit source or destination operand." Fixes piglit tests: - fs-multiply-const-ivec4 - fs-multiply-const-uvec4 - fs-multiply-ivec4-const - fs-multiply-uvec4-const Signed-off-by:
Kenneth Graunke <kenneth@whitecape.org> (cherry picked from commit 01044fce)
-
Dave Airlie authored
don't ask why I had to debug this. tested to fix g-s and kwin at 16-bpp on Ironlake. Signed-off-by:
Dave Airlie <airlied@redhat.com> (cherry picked from commit 7b642414)
-
Dave Airlie authored
If you ran g-s in 16-bpp we'd do a bunch of memory corruption. now it just misrenders for some other reasons. applies to stable. Signed-off-by:
Dave Airlie <airlied@redhat.com> Reviewed-by:
Brian Paul <brianp@vmware.com> (cherry picked from commit d6c5ad52)
-
Dave Airlie authored
piglit glx-tfp segfaults on llvmpipe when run vs a 16-bit radeon screen, it now fails instead of segfaulting, much prettier. Signed-off-by:
Dave Airlie <airlied@redhat.com> (cherry picked from commit 2c778375)
-
Vinson Lee authored
Fixes Coverity resource leak defect. NOTE: This is a candidate for the 8.0 branch. Signed-off-by:
Vinson Lee <vlee@freedesktop.org> Reviewed-by:
José Fonseca <jfonseca@vmware.com> Reviewed-by:
Kenneth Graunke <kenneth@whitecape.org> (cherry picked from commit 0f3aa9f4)
-
Brian Paul authored
The default was 32 for the EmitNoLoops=0 case. This allows the oZone3D soft shadows test to work properly with the vmware driver. Jose reported that SM3 supports up to 255 loop iterations. NOTE: This is a candidate for the 8.0 branch. Reviewed-by:
José Fonseca <jfonseca@vmware.com> (cherry picked from commit 20836c81)
-
Brian Paul authored
Instead of the hard-coded value of 32. Note that MaxUnrollIterations defaults to 32 so there's no net change. But the gallium state tracker can override this. NOTE: This is a candidate for the 8.0 branch. Reviewed-by:
Kenneth Graunke <kenneth@whitecape.org> (cherry picked from commit 7feabfe2)
-
Jeremy Huddleston Sequoia authored
<https://trac.macports.org/ticket/34499 > Regression-from: 51691f07 Signed-off-by:
Jeremy Huddleston <jeremyhu@apple.com> (cherry picked from commit 27b821bc)
-
Anuj Phogat authored
This is a squash of: intel: Fix a case when mapping large texture fails This patch handles a case when mapping a large texture fails in drm_intel_gem_bo_map_gtt(). These changes avoid assertion failure later in the driver as reported in following bugs: https://bugs.freedesktop.org/show_bug.cgi?id=44970 https://bugs.freedesktop.org/show_bug.cgi?id=46303 Testing: No regressions in piglit quick.tests Signed-off-by:
Anuj Phogat <anuj.phogat@gmail.com> (cherry picked from commit cdcfd5d1) and: intel: fix un-blanced map_refcount issue This is a regression introduced by commit cdcfd5, which forget to increase the map_refcount for successfully-mapped region. Thus caused a wrong non-blanced map_refcount. This would fix the regression found in the two following webglc testcase on Pineview platform: texture-npot.html gl-max-texture-dimensions.html Cc: Anuj Phogat <anuj.phogat@gmail.com> Signed-off-by:
Yuanhan Liu <yuanhan.liu@linux.intel.com> Reviewed-by:
Anuj Phogat <anuj.phogat@gmail.com> (cherry picked from commit 9cb777eb)
-
Anuj Phogat authored
Handle the special case of glFramebufferTextureLayer() for which we pass teximage = 0 internally in framebuffer_texture(). This patch makes failing piglit test fbo-array, fbo-depth-array to pass. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=47126 V4: Removed the duplicated code. Note: This is a candidate for the stable branches. Signed-off-by:
Anuj Phogat <anuj.phogat@gmail.com> Reviewed-by:
Brian Paul <brianp@vmware.com> (cherry picked from commit cc5b0ffa)
-
Kenneth Graunke authored
Unfortunately, Unigine Heaven 3.0 still needs this. NOTE: This is a candidate for the 8.0 branch. Signed-off-by:
Kenneth Graunke <kenneth@whitecape.org> Reviewed-by:
Eric Anholt <eric@anholt.net> (cherry picked from commit 60218b60)
-
Anuj Phogat authored
_mesa_max_texture_levels() is also used to test valid texture target in _mesa_GetTexLevelParameteriv(). GL_TEXTURE_CUBE_MAP is not allowed as texture target in glGetTexLevelParameter(). So, this should throw GL_INVALID_ENUM error. Few other functions which use _mesa_max_texture_levels() like getcompressedteximage_error_check() and getteximage_error_check() also don't accept GL_TEXTURE_CUBE_MAP. Above fix makes piglit fbo-cubemap test to fail. This is because of incorrect texture target passed to _mesa_max_texture_levels() in framebuffer_texture(). Fixing that as well Note: This is a candidate for the stable branches Signed-off-by:
Anuj Phogat <anuj.phogat@gmail.com> Reviewed-by:
Brian Paul <brianp@vmware.com> (cherry picked from commit a9523af0)
-
Kurt Roeckx authored
This is a direct port of the i915 patch in a856da63. Fixes glean's pbo test. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=41372 Reviewed-by:
Eric Anholt <eric@anholt.net> NOTE: This is a candidate for release branches. (cherry picked from commit 489ac8e7)
-
Kurt Roeckx authored
We were looking at the size of batch.map for how big the batchbuffer was, but on 865 we just use a single-page batchbuffer due to hardware limits. v2: Removed check for sizeof map < bo->size, since that's always false. [change by anholt] NOTE: This is a candidate for release branches. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=41495 (cherry picked from commit 024ece75)
-
Chris Wilson authored
In order to prevent an overflow of the batch buffer when emitting triangles, we need to limit the initial primitive to fit within the current batch. To do we need to measure the remaining space and thence compute the maximum number of vertices that fit into that space. Reported-by:
Kurt Roeckx <kurt@roeckx.be> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=41495 Signed-off-by:
Chris Wilson <chris@chris-wilson.co.uk> Reviewed-by:
Eric Anholt <eric@anholt.net> NOTE: This is a candidate for release branches. (cherry picked from commit 33b07893)
-
Alban Browaeys authored
The hardware, like i915, uses an inclusive bounds on min and max for the drawing rectangle, but we were providing a number for exclusive. The number of bits used by the hardware only covers this value going up to the maximum size, so when we programmed 2048 as the maximum inclusive X, it saw a maximum X of 0 and clipped all rendering. This caused rendering failures in gnome-shell. Fixes piglit fbo-maxsize. v2: dropped changes to the blitter, which does use an exclusive x2, y2. [change by anholt] Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=45558 Reviewed-by:
Eric Anholt <eric@anholt.net> NOTE: This is a candidate for release branches. (cherry picked from commit 7d13a6e6)
-