Skip to content
Snippets Groups Projects
  1. Nov 09, 2013
  2. Nov 07, 2013
  3. Nov 04, 2013
  4. Nov 01, 2013
  5. Oct 31, 2013
  6. Oct 30, 2013
  7. Oct 26, 2013
    • Alex Ashley's avatar
      hlsdemux: fix memory leak in gst_hls_demux_get_next_fragment · 07c669b4
      Alex Ashley authored
      This patch fixes three memory leaks in hlsdemux, one that occurs
      during normal operation and two that occur during error conditions.
      
      The gst_hls_demux_get_next_fragment function calls
      gst_fragment_get_buffer which increments the reference count
      on the buffer but gst_hls_demux_get_next_fragment never calls unref on
      the buffer. This means that the reference count for each downloaded
      fragment never gets to zero and so its memory is never released.
      
      This patch adds a call to gst_buffer_unref after the flags have been
      updated on the buffer.
      
      There is a leak-on-error in gst_hls_demux_decrypt_fragment if it fails
      to download the key file. If the key fails to download, null is
      returned without doing an unref on the encrypted fragment. The
      semantics of gst_hls_demux_decrypt_fragment is that it takes ownership
      of the encrypted fragment and releases it before returning.
      
      There is a leak-on-error in gst_hls_src_buf_to_utf8_playlist in the
      unlikely event that the gst_buffer_map fails. In the "happy path"
      operation of gst_hls_src_buf_to_utf8_playlist the buffer gets an unref
      before the function returns, therefore the error condition must do the
      same.
      
      https://bugzilla.gnome.org/show_bug.cgi?id=710881
      07c669b4
  8. Oct 25, 2013
  9. Oct 12, 2013
  10. Oct 10, 2013
  11. Oct 03, 2013
  12. Oct 01, 2013
  13. Sep 30, 2013
Loading