- Mar 28, 2018
-
-
Tim-Philipp Müller authored
-
Tim-Philipp Müller authored
-
- Mar 16, 2018
-
-
Even if it is the h264parse fault or bad video file, vaapih264dec should set a proper value for VAPictureParameterBufferH264.num_ref_frames as the driver might use it. Also see "info.ref_frames = dpb_size;" in gstvaapidecoder_h264.c::ensure_context https://bugzilla.gnome.org/show_bug.cgi?id=793836
-
- Mar 01, 2018
-
-
Víctor Manuel Jáquez Leal authored
The allocator in the config may be not VAAPI (videotestsrc, for example) and it will not have a video info configuration. https://bugzilla.gnome.org/show_bug.cgi?id=789476
-
- Feb 20, 2018
-
-
Víctor Manuel Jáquez Leal authored
When deinterlacing with VPP the discont flag was not forwarded to the new created buffer. This patch sets the discont flag if input buffer has it.
-
- Feb 08, 2018
-
-
Víctor Manuel Jáquez Leal authored
In propose_allocation() if the numer of allocation params is zero, the system's allocator is added first, and lastly the native VA-API allocator. https://bugzilla.gnome.org/show_bug.cgi?id=789476
-
Víctor Manuel Jáquez Leal authored
GST_VAAPI_VIDEO_ALLOCATOR_NAME was added in commit 5b11b833 but it was never used, since the native VA-API allocator name has been GST_VAAPI_VIDEO_MEMORY_NAME. This patch removes GST_VAAPI_VIDEO_ALLOCATOR_NAME macro. https://bugzilla.gnome.org/show_bug.cgi?id=789476
-
- Jan 30, 2018
-
-
The array needs to be NULL-terminated according to the gst_plugin_add_dependency() documentation.
-
- Jan 12, 2018
-
-
gst_vaapipostproc_ensure_filter might free the allowed_srcpad_caps and allowed_sinkpad_caps. This can race with copying these caps in gst_vaapipostproc_transform_caps and lead to segfaults. The gst_vaapipostproc_transform_caps function already locks postproc_lock before copying the caps. Make sure that calls to gst_vaapipostproc_ensure_filter also acquire this lock.
-
- Dec 07, 2017
-
-
Sebastian Dröge authored
-
- Oct 19, 2017
-
-
In VA-API 1.0 the enum VAEncPackedHeaderH264_SEI is deprecated, and instead VAEncPackedHeaderRawData should be used. This patch creates a compatibility symbol, VA_ENC_PACKED_HEADER_H264_SEI, to expose the used enum according the VA-API version. https://bugzilla.gnome.org/show_bug.cgi?id=784398
-
In VA-API 1.0 the H.264 baseline profile is deprecated. This patch guards the H.264 baseline usage. Consider this commit as a continuation of commit e0e0a474 https://bugzilla.gnome.org/show_bug.cgi?id=784398
-
The logging mechanism in libva has changed it's functions signatures. This patch updates that for libva versions >= 1.0 https://bugzilla.gnome.org/show_bug.cgi?id=784398
-
libva 1.0 deprecated H.264 baseline profile and FMO support (commit b4f332b3). https://bugzilla.gnome.org/show_bug.cgi?id=784398
-
Intel's MSDK uses libva 0.99.0, meanwhile open source libva bumped its API version to 1.0.0. Thus we have to blacklist only the MSDK's libva (0.99.0) https://bugzilla.gnome.org/show_bug.cgi?id=784398
-
- Sep 26, 2017
-
-
Víctor Manuel Jáquez Leal authored
Flush pending frames, if any, in the internal encorder, before setting the new negotiated format. https://bugzilla.gnome.org/show_bug.cgi?id=786173
-
Víctor Manuel Jáquez Leal authored
Drain pending frames, if any, in the internal decoder before setting the new negotiated format. https://bugzilla.gnome.org/show_bug.cgi?id=786173
-
- Sep 25, 2017
-
-
Fixes regression introduced by commit 2eb2b26a. There is a use case when the decoder set the src caps and immediatly tries to process the media codec_data, this happens before decoder is even opened, thus priv->parser is not instantiated yet. https://bugzilla.gnome.org/show_bug.cgi?id=787818
-
Víctor Manuel Jáquez Leal authored
When updating the caps in decoder, if the caps has codec_data (avC format), it has to be parsed to update the state of the decoder. https://bugzilla.gnome.org/show_bug.cgi?id=786173
-
- Sep 18, 2017
-
-
Sebastian Dröge authored
-
- Sep 15, 2017
-
-
Víctor Manuel Jáquez Leal authored
This patch fixes a regression introduced in commit 148f867c, since the props variable is set to object's member variable encoder->properties. And it is set in the instance initialization, thus it will not be leaked. https://bugzilla.gnome.org/show_bug.cgi?id=787733
-
- Aug 24, 2017
-
-
Víctor Manuel Jáquez Leal authored
Coverity scan bug: An assigned value that is never used may represent unnecessary computation, an incorrect algorithm, or possibly the need for cleanup or refactoring. ip_period is assigned first to be rewritter inmediatly after. The first assignation is spurious.
-
Víctor Manuel Jáquez Leal authored
Coverity scan: Logically dead code: The indicated dead code may have performed some action; that action will never occur. By using pointer arithmetic is impossible to get NULL.
-
Víctor Manuel Jáquez Leal authored
Converity scan bug: If the function returns an error value, the error value may be mistaken for a normal value. If g_atomic_pointer_compare_and_exchange() fails because the frame is not the last one, the function fails. Thus, logging an info message.
-
Víctor Manuel Jáquez Leal authored
Coverity scan bug: If the function returns an error value, the error value may be mistaken for a normal value. Function sscanf returns the number of assignations done. Validate this return value with the number of expected variables to match.
-
Víctor Manuel Jáquez Leal authored
Coverity scan bug: Dereference after null check: Either the check against null is unnecessary, or there may be a null pointer dereference. Variable klass has been validated as non-NULL several time before in gst_vaapi_object_new() function, so there is no need to check it again.
-
Víctor Manuel Jáquez Leal authored
Coverity scan bug: An assigned value that is never used may represent unnecessary computation, an incorrect algorithm, or possibly the need for cleanup or refactoring. ip_period is assigned first to be rewritter inmediatly after. The first assignation is spurious.
-
Víctor Manuel Jáquez Leal authored
Coverity scan bug: Unintentional integer overflow. The expression's value may not be what the programmer intended, because the expression is evaluated using a narrow (i.e. few bits) integer type. Cast operator to guint64 before computation to avoid narrowing. merge with 3c5a6add
-
Víctor Manuel Jáquez Leal authored
Coverity scan bug: An assigned value that is never used may represent unnecessary computation, an incorrect algorithm, or possibly the need for cleanup or refactoring. In the return value of decode_slice() or gst_mpeg4_parse_video_packet_header() are not success, thus fail decode_packet() function.
-
Víctor Manuel Jáquez Leal authored
Coverity scan bug: Dereference after null check: Either the check against null is unnecessary, or there may be a null pointer dereference. While looking for hte lowest poc, according to rest of the code, the picture in the dbp (decoded picture buffer) might be NULL, thus we could check for a NULL picture before assigned as found. Also, split a comma operator because it is considered as a bad practice because it possible side effects.
-
Víctor Manuel Jáquez Leal authored
Coverity scan bug: Scalars (for example, integers) are not properly bounds-checked (sanitized) before being used as array or pointer indexes, loop boundaries, or function arguments are considered as tainted. In this case, num_nals were not checked before used as loop control.
-
Víctor Manuel Jáquez Leal authored
Coverity scan bug: Dereference after null check: Either the check against null is unnecessary, or there may be a null pointer dereference. In the original commit for fill_picture_gaps() (commit 5abd2b90) the prev_picture could be NULL, that's why the code did a null check. But, since commit 52adebe7, the previous reference frames are tracked, thus there is no need to check null anymore.
-
Víctor Manuel Jáquez Leal authored
An unsigned value can never be negative, so this test (greater than zero) will always evaluate the same way. Thus change it to just if it's not zero.
-
Víctor Manuel Jáquez Leal authored
Refactor gst_vaapi_plugin_base_create_gl_context() in order to check the return value of gst_gl_ensure_element_data(). The result is a code bit cleaner.
-
Víctor Manuel Jáquez Leal authored
By using #elif macro, the static code analysis would stop to detect these lines as dead code. Also it is inforced the mutually exclusive environments.
-
Víctor Manuel Jáquez Leal authored
The function g_bit_nth_lsf() may return -1 if the request bit position is not avaible. Thus, this patch check if the return value is not -1 in order to continue.
-
Víctor Manuel Jáquez Leal authored
-
Víctor Manuel Jáquez Leal authored
-