Skip to content
Snippets Groups Projects
Commit a548b727 authored by Bas Nieuwenhuizen's avatar Bas Nieuwenhuizen
Browse files

ac/nir: Only clamp shadow reference on radeonsi.


Vulkan CTS does not expect the value to be clamped (at least for D32),
and it makes a differences even though depth is in [0,1], due
to strict inequalities.

I couldn't find anything in the Vulkan spec about this, but the test
seemed to be copied from GL tests and the GL spec only specifies
clamping for fixed point formats. Hence I expect radeonsi to run into
this at some point as well, but given that they still have a usecase
with the Z16->Z32 promotion, I'll leave that for someone else to clean
up.

This at least fixes radv dEQP-VK.texture.shadow.* on VI.

Fixes: 0f9e3251 'ac/nir: clamp shadow texture comparison value on VI'
Reviewed-by: default avatarDave Airlie <airlied@redhat.com>
parent c07d719e
No related branches found
No related tags found
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment