Skip to content
Snippets Groups Projects
Commit 7b5e9336 authored by Francisco Jerez's avatar Francisco Jerez Committed by Marge Bot
Browse files

intel/fs: Fix src and dst types of LOAD_PAYLOAD ACP entries during copy propagation.


The ACP entries created by copy propagation to track the implied
copies of LOAD_PAYLOAD instructions don't model the behavior of
LOAD_PAYLOAD correctly, since (as of 41868bb6) header
moves are implicitly retyped to UD and the destination of non-header
copies implicitly uses the same type as the corresponding source, even
though the ACP entries created for such copies could incorrectly
represent a type conversion, which can lead to mis-optimization of the
program.

According to Marcin, this fixes the func.mesh.ext.workgroup_id.task.q0
crucible test.

Fixes: 41868bb6 ("i965/fs: Rework the fs_visitor LOAD_PAYLOAD instruction")
Reported-by: default avatarMarcin Ślusarz <marcin.slusarz@intel.com>
Tested-by: default avatarMarcin Ślusarz <marcin.slusarz@intel.com>
Reviewed-by: default avatarIan Romanick <ian.d.romanick@intel.com>
Part-of: <mesa/mesa!18980>
parent 51b8abe0
No related branches found
No related tags found
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment