Skip to content
Snippets Groups Projects
Commit 01185dcd authored by Marek Olšák's avatar Marek Olšák Committed by Eric Engestrom
Browse files

util: fix util_is_vbo_upload_ratio_too_large


It was wrong. For example, if the draw vertex count was 10 and the upload
vertex count was 150, u_vbuf wouldn't unroll the draw and would instead
memcpy 150 vertices. This fixes that case.

Fixes: 068a3bf0 - util: move and adjust the vertex upload heuristic equation from u_vbuf

Reviewed-by: default avatarPierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <mesa/mesa!20824>
(cherry picked from commit 4f6e7858)
parent 6c869d99
No related branches found
No related tags found
Loading
......@@ -1948,7 +1948,7 @@
"description": "util: fix util_is_vbo_upload_ratio_too_large",
"nominated": true,
"nomination_type": 1,
"resolution": 0,
"resolution": 1,
"main_sha": null,
"because_sha": "068a3bf0d7cda0301b3dfc2e258698c6848ca706"
},
......
......@@ -785,9 +785,9 @@ static inline bool
util_is_vbo_upload_ratio_too_large(unsigned draw_vertex_count,
unsigned upload_vertex_count)
{
if (draw_vertex_count > 1024)
if (upload_vertex_count > 256)
return upload_vertex_count > draw_vertex_count * 4;
else if (draw_vertex_count > 32)
else if (upload_vertex_count > 64)
return upload_vertex_count > draw_vertex_count * 8;
else
return upload_vertex_count > draw_vertex_count * 16;
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment