- Feb 05, 2016
-
-
Peter Hutterer authored
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
-
Peter Hutterer authored
If a USB keyboard like the YubiKey is found before the internal keyboard, it will be paired with the touchpad when it is seen. The internal keyboard is seen later bug ignored because we already have a keyboard paired with the touchpad. This is obviously wrong. For now, give priority to serio keyboards, and override existing dwt pairings with the new keyboard. https://bugs.freedesktop.org/show_bug.cgi?id=93983 Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net> Reviewed-by: Hans de Goede <hdegoede@redhat.com> (cherry picked from commit 0b0150e0)
-
Peter Hutterer authored
If a key enables dwt and is held down when the timeout expires, re-issue the timeout. There is a corner case where dwt may not work as expected: 1. key down and held down 2. dwt timer expires, dwt is re-issued 3. touch starts 4. key is released 5. dwt timer expires 6. touch now starts moving the pointer This is an effect of the smart touch detection. A touch starting after the last key press is released for pointer motion once dwt turns off again. This is what happens in the above case, the dwt timer expiring is the last virtual key press. This is a corner case and likely hard to trigger by a real user. https://bugs.freedesktop.org/show_bug.cgi?id=93984 Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net> Reviewed-by: Hans de Goede <hdegoede@redhat.com> (cherry picked from commit b27f0468)
-
Peter Hutterer authored
Some older touchpad devices jitter a fair bit when a finger is resting on the touchpad. That's why the hysteresis was introduced in the synaptics driver back in 2011. However, the default value of the hysteresis in the synaptics driver ended up being 0, even though the code looks like it's using a fraction of the touchpad diagonal. When the hysteresis code was ported to libinput it was eventually set to 0.5mm. Turns out this is still too high and tiny finger motions are either nonreactive or quite jumpy, making it hard to select small targets. Drop the default hysteresis by reducing its margin to 0, but leave it in place for those devices where we need them (e.g. the cyapa touchpads). https://bugs.freedesktop.org/show_bug.cgi?id=93503 Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net> Reviewed-by: Hans de Goede <hdegoede@redhat.com> (cherry picked from commit 6e0553ab5553d63fa737c1739cfa86fbeee9f641)
-
Peter Hutterer authored
This was the reason for the valgrind test case failures whenever we accumulated too many tests (see 9c2afae1 and 2a110104). The cause was simply that we ran out of fds which caused libevdev to fail the scandir() searching for the event node. That resulted in a NULL devnode and an abort in litest. Close the fd before freeing the evdev device. Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net> (cherry picked from commit a84bf167)
-
Peter Hutterer authored
This button sends a release N, press N+1 on each press, cycling through the three event codes supported. This causes a stuck button since the current mode is never released. Long-term this better served by a set of switches that toggle accordingly, for now disable the button codes. https://bugs.freedesktop.org/show_bug.cgi?id=92127 Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net> Reviewed-by: Hans de Goede <hdegoede@redhat.com> (cherry picked from commit e19d5d22)
-
Peter Hutterer authored
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net> (cherry picked from commit b6f59d0e)
-
Peter Hutterer authored
We have a specific semi-mt 2fg scroll test for those. Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net> (cherry picked from commit c352a502)
-
Peter Hutterer authored
Some of the 2-slot touchpads don't do gestures though (e.g. semi-mt) so skip those. And change the movement granularity for the pinch and spread tests so we stay under one degree angle for lower-resolution touchpads too. Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net> (cherry picked from commit ff2ee2c6)
-
- Feb 04, 2016
-
-
Peter Hutterer authored
litest-selftest.c: In function ‘litest_ptr_eq_notrigger’: litest-selftest.c:172:10: warning: initialization makes integer from pointer without a cast [-Wint-conversion] int c = NULL; ^ litest-selftest.c:173:10: warning: initialization makes integer from pointer without a cast [-Wint-conversion] int d = NULL; ^ Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net> (cherry picked from commit 82335b0a)
-
- Jan 25, 2016
-
-
Peter Hutterer authored
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
-
Peter Hutterer authored
No point trying to detect pinch gestures if we only have one set of coordinates. This makes two-finger scrolling on ST touchpads more reactive. Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net> Reviewed-by: Hans de Goede <hdegoede@redhat.com> (cherry picked from commit 28205d6f)
-
Peter Hutterer authored
Synaptics, Elantech and Alps semi-mt devices all have issues with reporting correct MT data, even the bounding box which semi-mt devices are supposed to report is wrong. Synaptics devices have massive jumps with two fingers down. Elantech devices may open slots without coordinate data. Alps devices may send 0/0 coordinates as initial slot position. All these may be addressable with specific quirks, but the actual benefit is largely restricted to better palm detection (though even with quirks this is unlikely to work) and support for pinch gestures (again, lack of coordinates makes supporting those hard anyway). Elantech: https://bugs.freedesktop.org/show_bug.cgi?id=93583 Alps: https://bugzilla.redhat.com/show_bug.cgi?id=1295073 Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net> Reviewed-by: Hans de Goede <hdegoede@redhat.com> (cherry picked from commit 342bc510)
-
Peter Hutterer authored
More accurate representation of what we actually want to do. Plus it avoids weird test case failures in semi-mt where we always pick the t/l and b/r touches for the bounding box. That is the proper behavior for semi-mt, but it's not for the tests where we expect simultaneous finger movement. Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net> Reviewed-by: Hans de Goede <hdegoede@redhat.com> (cherry picked from commit d19307f2)
-
Peter Hutterer authored
When three fingers are set down on the touchpad, one finger tends to get a 0/0 coordinate, triggering palm detection in the upper left corner. Handle this like the jumping semi-mt touchpads and disable MT handling and instead just rely on the x/y axis and the BTN_TOOL_* events. https://bugs.freedesktop.org/show_bug.cgi?id=93583 This kernel patch is required: https://lkml.org/lkml/2016/1/11/171 Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net> Reviewed-by: Hans de Goede <hdegoede@redhat.com> (cherry picked from commit 556aac04)
-
Peter Hutterer authored
Otherwise the first word is used as section header and discarded from the output. Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net> (cherry picked from commit 41cc9053)
-
Peter Hutterer authored
A fake MT device may have ABS_MT_POSITION_X but not Y. In this case we don't care, because we don't handle those axes anyway. http://bugs.freedesktop.org/show_bug.cgi?id=93474 Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net> Reviewed-by: Hans de Goede <hdegoede@redhat.com> (cherry picked from commit 988cfda4)
-
Label internal keyboards through the udev hwdb and only pair the internal (usb) Apple touchpads with those keyboards labelled as such. https://bugs.freedesktop.org/show_bug.cgi?id=93367 Co-authored-by: Peter Hutterer <peter.hutterer@who-t.net> Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net> Reviewed-by: Hans de Goede <hdegoede@redhat.com> (cherry picked from commit b3f11180)
-
- Dec 22, 2015
-
-
Peter Hutterer authored
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
-
Peter Hutterer authored
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
-
- Dec 18, 2015
-
-
Peter Hutterer authored
open_restricted() doesn't always mean 'open the fd'. When the X server uses systemd-logind, the fd is opened once before PreInit and then kept open across devices being disabled and enabled through the protocol. When the device is re-enabled and libinput_path_add_device is called for the device, we may have events pending on the fd, leaking information that we should just ignore. There's also the potential of inconsistent state. The kernel updates the device state whenever it processes an event, the evdev ioctls return that state. If events are pending, the state we see is newer than the events we process immediately after initialization. That can lead to confusion. Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net> Reviewed-by: Hans de Goede <hdegoede@redhat.com>
-
- Dec 15, 2015
-
-
Peter Hutterer authored
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
-
- Dec 13, 2015
-
-
Peter Hutterer authored
If an x220 is updated to the touchpad firmware version 8.1, the touchpad suffers from the same issues as the x230 and needs custom acceleration code. Unfortunately we cannot detect this otherwise, so it is left to the user as a custom hwdb setting. https://bugzilla.redhat.com/show_bug.cgi?id=1264453 Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net> Reviewed-by: Hans de Goede <hdegoede@redhat.com>
-
Peter Hutterer authored
Avoid empty statements and force the caller to terminate the macro. Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
-
Peter Hutterer authored
The file is already larger than 4k, so we ended up truncating the file for the tests. This went unnoticed until recent additions that ended up truncating it halfway through an assignment. Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
-
- Dec 10, 2015
-
-
Peter Hutterer authored
More flexible than having values that are device-specific. Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
-
Peter Hutterer authored
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net> (cherry picked from commit d070463a)
-
Converts two doubles to 24.8 fixed-width integers so assertions can be made with doubles in tests Signed-off-by: Stephen Chandler Paul <thatslyude@gmail.com> Reviewed-by: Peter Hutterer <peter.hutterer@who-t.net> (cherry picked from commit 9d96286a)
-
- Dec 08, 2015
-
-
Peter Hutterer authored
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
-
- Dec 07, 2015
-
-
Peter Hutterer authored
Once we trigger diagonal scrolling, the device's scroll direction is set as horiz+vert. From then on, both axes will be set on every subsequent scroll event, even when the actual delta for an axis is 0. This causes continuous scroll stop events in clients that care about these things. Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net> Reviewed-by: Hans de Goede <hdegoede@redhat.com>
-
Peter Hutterer authored
We dont' want to fill up the event queue and cause SYN_DROPPED events. Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net> Reviewed-by: Hans de Goede <hdegoede@redhat.com>
-
Peter Hutterer authored
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net> Reviewed-by: Hans de Goede <hdegoede@redhat.com>
-
- Dec 02, 2015
-
-
Peter Hutterer authored
If all fingers are released in the same frame, we won't be able to find the top-most touch. https://bugs.freedesktop.org/show_bug.cgi?id=93204 Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net> Reviewed-by: Hans de Goede <hdegoede@redhat.com>
-
Peter Hutterer authored
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net> Reviewed-by: Hans de Goede <hdegoede@redhat.com>
-
Peter Hutterer authored
If the test is filtered out and we never run it generates a false positive. Though it isn't listed in the "Checks" summary this is a bit hard to tell when you're running >700 tests. Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net> Reviewed-by: Hans de Goede <hdegoede@redhat.com>
-
Peter Hutterer authored
These aren't real button events and they are handled elsewhere, either through proper touch events on touchscreen or through custom handling in the touchpad case. https://bugs.freedesktop.org/show_bug.cgi?id=93165 Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net> Reviewed-by: Hans de Goede <hdegoede@redhat.com>
-
Peter Hutterer authored
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
-
- Nov 15, 2015
-
-
Peter Hutterer authored
At least on the t440, this is enough to trigger correct detection between pinch and scroll 90% of the time. Since scrolling is significantly more prevalent than gesturing, erring on the side of scrolling at the cost of misdetecting some gestures is acceptable. Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net> Reviewed-by: Hans de Goede <hdegoede@redhat.com>
-
Peter Hutterer authored
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
-
Peter Hutterer authored
And link the software buttons sentence to the t440 page. Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
-