- Aug 07, 2024
-
-
Eric Engestrom authored
-
using EGL_DEFAULT_DISPLAY will cover the swrast case, which fixes generating all the correct configs Fixes: ec7afd2c ("dril: rework config creation") Reviewed-by:
Eric Engestrom <eric@igalia.com> Part-of: <mesa/mesa!30426> (cherry picked from commit ef88af84)
-
Eric Engestrom authored
-
v_swap_b16 is not offically supported as VOP3, so it can't be used with v128-255. Tests show that VOP3 appears to work correctly, but according to AMD that should not be relied on. https://github.com/llvm/llvm-project/pull/100442#discussion_r1703929676 Foz-DB Navi31: Totals from 6 (0.01% of 79395) affected shaders: Instrs: 64799 -> 65932 (+1.75%) CodeSize: 360180 -> 368440 (+2.29%) Latency: 1364648 -> 1365922 (+0.09%) InvThroughput: 635843 -> 636475 (+0.10%) Copies: 14766 -> 15698 (+6.31%) VALU: 38743 -> 39675 (+2.41%) Fixes: 80b8bbf0 ("aco/gfx11: use v_swap_b16") Reviewed-by:
Rhys Perry <pendingchaos02@gmail.com> Reviewed-by:
Timur Kristóf <timur.kristof@gmail.com> Part-of: <mesa/mesa!30515> (cherry picked from commit e0818cb8)
-
Replicating what we do in genX_cmd_compute.c Signed-off-by:
Lionel Landwerlin <lionel.g.landwerlin@intel.com> Fixes: 7ca5c848 ("anv: add support for simple internal compute shaders") Reviewed-by:
Tapani Pälli <tapani.palli@intel.com> Part-of: <mesa/mesa!30539> (cherry picked from commit 4f093b2e)
-
Signed-off-by:
Rhys Perry <pendingchaos02@gmail.com> Reviewed-by:
Georg Lehmann <dadschoorse@gmail.com> Fixes: cc404d45 ("aco: remove perfwarn") Part-of: <mesa/mesa!30519> (cherry picked from commit 373851e7)
-
Signed-off-by:
Rhys Perry <pendingchaos02@gmail.com> Reviewed-by:
Georg Lehmann <dadschoorse@gmail.com> Fixes: 48461c0d ("aco: enable VOPD scheduler") Part-of: <mesa/mesa!30519> (cherry picked from commit e45035c8)
-
This is needed to ensure correct synchronization in kernel eg. when it moves the buffers between VRAM and GTT. Backport-to: 24.2 Closes: drm/amd#3437 Closes: mesa/mesa#11624 Reviewed-by:
Boyuan Zhang <Boyuan.Zhang@amd.com> Part-of: <mesa/mesa!30510> (cherry picked from commit 0c024bbe)
-
Eric Engestrom authored
-
Xe KMD will now report the different topology mask types based on the type of the EU of running platform. With this we don't need to divide the EU count by 2 in intel_perf. Reviewed-by:
Lionel Landwerlin <lionel.g.landwerlin@intel.com> Signed-off-by:
José Roberto de Souza <jose.souza@intel.com> (cherry picked from commit 132c5cde) Part-of: <mesa/mesa!30522>
-
Sync xe_drm.h with f2881dfdaaa9 ("drm/xe/oa/uapi: Make bit masks unsigned"). Reviewed-by:
Lionel Landwerlin <lionel.g.landwerlin@intel.com> Signed-off-by:
José Roberto de Souza <jose.souza@intel.com> (cherry picked from commit 3da911b0) Part-of: <mesa/mesa!30522>
-
- Aug 06, 2024
-
-
When we switch to the full nir based glsl linker in an upcomming merge request this is required for existing tests from 8fcf8e7f to continue to pass, this is because they never exercised glsl to nir so the missing support went unnoticed. Closes: mesa/mesa#11456 Fixes: 8fcf8e7f ("glsl: lower builtins to mediump that ignore precision of certain parameters ") Reviewed-by:
Marek Olšák <marek.olsak@amd.com> Part-of: <mesa/mesa!30395> (cherry picked from commit 140ca7e5)
-
If TraceRay() is called with the TerminateOnFirstHit flag, we need to terminate the ray on the first confirmed intersection. This is handled by the lowering of accept_ray_intersection and it's working fine for the case of multiple instances of the intersection shader being called. But if the shader calls reportIntersection() more than once, we were handling them all and accepting the closest one regardless of the flag. Check for the flag on every confirmed intersection and, if set, accept it right there. The subsequent lowering will take care of terminating handling the ray termination if necessary. Fixes new test dEQP-VK.ray_tracing_pipeline.amber.flags-accept-first Cc: mesa-stable Reviewed-by:
Ian Romanick <ian.d.romanick@intel.com> Part-of: <mesa/mesa!30418> (cherry picked from commit f8553f56)
-
The current code is not handling the potential NULL pointer in VkDebugUtilsObjectNameInfoEXT::pObjectName Signed-off-by:
Lionel Landwerlin <lionel.g.landwerlin@intel.com> Fixes: e1b9a6e4 ("anv: initial RMV support") Reviewed-by:
Faith Ekstrand <faith.ekstrand@collabora.com> Part-of: <mesa/mesa!30516> (cherry picked from commit c6bf1f02)
-
VkDebugUtilsObjectNameInfoEXT::pObjectName can be NULL [1] : "Applications may change the name associated with an object simply by calling vkSetDebugUtilsObjectNameEXT again with a new string. If pObjectName is either NULL or an empty string, then any previously set name is removed." The current code will segfault. [1] : https://registry.khronos.org/vulkan/specs/1.3-extensions/html/chap50.html#VkDebugUtilsObjectNameInfoEXT Signed-off-by:
Lionel Landwerlin <lionel.g.landwerlin@intel.com> Fixes: 3b361b23 ("vulkan: Implement VK_EXT_debug_utils") Reviewed-by:
Faith Ekstrand <faith.ekstrand@collabora.com> Part-of: <mesa/mesa!30516> (cherry picked from commit ae9a249d)
-
this had a number of issues: * pipe_loader_get_driinfo_xml() frees driver_driconf immediately, except the driOptionCache struct string pointers are all just copied in merge_driconf instead of having the strings copied, which means any subsequent access of driver_driconf strings is invalid access * pipe_loader_drm_get_driconf_by_name() is a disaster that only happened to work because the dlopen here is the same lib that gets opened elsewhere by mesa and not closed. if the lib here is actually closed, then all the statically allocated strings become invalid, which means they need to be manually copied cc: mesa-stable Reviewed-by:
Marek Olšák <marek.olsak@amd.com> Part-of: <mesa/mesa!30494> (cherry picked from commit 0c220741)
-
We increased VS_EXPORT_COUNT to 8 for streamout in gfx10_shader_ngg, but we forgot to increase the attribute ring stride, causing all waves except the first one to get corrupted VS outputs. Fixes: f703dfd1 - radeonsi: add gfx12 Reviewed-by:
Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com> Part-of: <mesa/mesa!30503> (cherry picked from commit 0e27df45)
-
Fixes: f703dfd1 - radeonsi: add gfx12 Reviewed-by:
Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com> Part-of: <mesa/mesa!30503> (cherry picked from commit 07a0b5e2)
-
This fixes random GPU hangs on gfx12 due to incoherent indirect buffer data, causing random indirect vertex and instance counts, which timeouts if the random numbers are large. Fixes: a8abbbb1 - radeonsi: remove r600_pipe_common.h Reviewed-by:
Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com> Part-of: <mesa/mesa!30503> (cherry picked from commit 83b88c54)
-
There was a case where if we don't sync, we wouldn't set TC_L2_dirty either, which could cause problems later. Fixes: f703dfd1 - radeonsi: add gfx12 Reviewed-by:
Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com> Part-of: <mesa/mesa!30503> (cherry picked from commit ebc5116e)
-
I guess incorrect packet interrupts have been enabled, so this started hanging. radeon_set_context_reg_seq shouldn't be used with gfx12_set_context_reg. Fixes: f703dfd1 - radeonsi: add gfx12 Reviewed-by:
Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com> Part-of: <mesa/mesa!30503> (cherry picked from commit e4b3848f)
-
Fixes: cc33cafc ("nak/nir: Use an indirect load for sample locations") Part-of: <mesa/mesa!29194> (cherry picked from commit 761874ea)
-
Dota 2 and Counter-Strike 2 really want to be able to allocate memory for both VkImages and VkBuffers from the same memory type. Xe2's special compression-only memory type does not support buffers, which makes these games crash. Disable CCS on these games as a workaround. This is a temporary workaround as we're still working towards a long-term solution (either by fixing the engine or finding a way better expose our memory types). Backport-to: 24.2 Fixes: mesa/mesa#11520 Fixes: mesa/mesa#11521 Reviewed-by:
José Roberto de Souza <jose.souza@intel.com> Reviewed-by:
Jianxun Zhang <jianxun.zhang@intel.com> Signed-off-by:
Paulo Zanoni <paulo.r.zanoni@intel.com> Part-of: <mesa/mesa!30481> (cherry picked from commit 644dcc03)
-
These memory types are useless when CCS is disabled, don't leave them there so they don't confuse applications. Backport-to: 24.2 Reviewed-by:
José Roberto de Souza <jose.souza@intel.com> Reviewed-by:
Jianxun Zhang <jianxun.zhang@intel.com> Signed-off-by:
Paulo Zanoni <paulo.r.zanoni@intel.com> Part-of: <mesa/mesa!30481> (cherry picked from commit b4f5a042)
-
Signed-off-by:
Rhys Perry <pendingchaos02@gmail.com> Reviewed-by:
Georg Lehmann <dadschoorse@gmail.com> Fixes: 284b9965 ("aco/gfx11.5+: allow sgpr dst for trans ops and use pseudo scalar ops on gfx12") Part-of: <mesa/mesa!30477> (cherry picked from commit 911fdce0)
-
Cc: mesa-stable Part-of: <mesa/mesa!30504> (cherry picked from commit b3e925a2)
-
Cc: mesa-stable Acked-by:
Mike Blumenkrantz <michael.blumenkrantz@gmail.com> Reviewed-by:
Georg Lehmann <dadschoorse@gmail.com> Part-of: <mesa/mesa!30504> (cherry picked from commit b2225b94)
-
Cc: mesa-stable Acked-by:
Mike Blumenkrantz <michael.blumenkrantz@gmail.com> Reviewed-by:
Georg Lehmann <dadschoorse@gmail.com> Part-of: <mesa/mesa!30504> (cherry picked from commit 39ec184d)
-
Passing all of deqp-gles* LRZ is still causing some artifacts in games so it is disabled for now. Signed-off-by:
Rob Clark <robdclark@chromium.org> Part-of: <mesa/mesa!30304> (cherry picked from commit ad90bf05)
-
Regs are different, and a750+ gets new configuration for VPC cache in GMEM. Signed-off-by:
Rob Clark <robdclark@chromium.org> Part-of: <mesa/mesa!30304> (cherry picked from commit e6be78c7)
-
Consolidate the various uses of CP_EVENT_WRITE into helpers, and use use fd_gpu_event to manage the differences between a6xx and a7xx. This is a bit churny as it spreading a fair bit of the CHIP template param around. Signed-off-by:
Rob Clark <robdclark@chromium.org> Part-of: <mesa/mesa!30304> (cherry picked from commit 1f41d590)
-
On later GPUs this buffer is also used for direction tracking, etc. Meaning that it is not optional. Signed-off-by:
Rob Clark <robdclark@chromium.org> Part-of: <mesa/mesa!30304> (cherry picked from commit b1937f76)
-
Signed-off-by:
Rob Clark <robdclark@chromium.org> Part-of: <!30304> (cherry picked from commit 679e9093)
-
And re-use in gallium driver. Signed-off-by:
Rob Clark <robdclark@chromium.org> Part-of: <mesa/mesa!30304> (cherry picked from commit beb5577e)
-
And re-use them in the gallium driver Signed-off-by:
Rob Clark <robdclark@chromium.org> Part-of: <mesa/mesa!30304> (cherry picked from commit 5c34a5e5)
-
Signed-off-by:
Rob Clark <robdclark@chromium.org> Part-of: <mesa/mesa!30304> (cherry picked from commit a6c9f152)
-
Signed-off-by:
Rob Clark <robdclark@chromium.org> Part-of: <mesa/mesa!30304> (cherry picked from commit 31302ca1)
-
Signed-off-by:
Rob Clark <robdclark@chromium.org> Part-of: <mesa/mesa!30304> (cherry picked from commit 8ff33a75)
-
If this is a 64b reg, we should write both halves. Signed-off-by:
Rob Clark <robdclark@chromium.org> Part-of: <mesa/mesa!30304> (cherry picked from commit 10eaf06e)
-
Useful to track down issues related to uninitialized regs. Signed-off-by:
Rob Clark <robdclark@chromium.org> Part-of: <mesa/mesa!30304> (cherry picked from commit 1a3f041c)
-