Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • pulseaudio pulseaudio
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 895
    • Issues 895
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 48
    • Merge requests 48
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar

Due to an influx of spam, we have had to impose restrictions on new accounts. Please see this wiki page for instructions on how to get full permissions. Sorry for the inconvenience.

  • PulseAudioPulseAudio
  • pulseaudiopulseaudio
  • Merge requests
  • !752

alsa: ucm: Fix spurious mixer path removal on initial profile set

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Hector Martin requested to merge marcan/pulseaudio:ucm-fix into master Nov 17, 2022
  • Overview 8
  • Commits 1
  • Pipelines 2
  • Changes 1

The code that removes the mixer path if probing fails can be called in the path that sets a non-off device profile on hotplug before card->active_profile is updated, which results in spuriously removing the mixer path. By this point, context->ucm->active_verb would be set to the same as the profile name, so we can use that instead to avoid the issue.

On Apple Silicon machines with the UCM profiles in the Asahi Linux repo, this manifests as the headphones jack having hardware volume controls only if PA is started with headphones connected and until they are disconnected. Hotplugs end up triggering the bad codepath, and it falls back to software volume (which is particularly a problem when the hardware volume happens to be very low or 0 at that point).

Fixes: a9cc1373 ("alsa: ucm - update the mixer path also after volume probe")

Signed-off-by: Hector Martin marcan@marcan.st

Edited Nov 17, 2022 by Hector Martin
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: ucm-fix