Skip to content

fix handling of symbolic port names in zsh completion

pseyfert requested to merge pseyfert/pulseaudio:master into master

on my device LC_MESSAGES=C pactl list sinks prints (among other lines)

	Ports:
		[Out] Speaker: Speaker (type: Speaker, priority: 100, availability unknown)
		[Out] Headphones: Headphones (type: Headphones, priority: 200, not available)

The current zsh completion assumes symbolic port names are "everything before the first colon with spaces removed" instead of "everything before the first colon with leading spaces removed". This is changed in this MR.

before zsh completes for me

pactl set-sink-port alsa_output.pci-0000_00_1f.3-platform-skl_hda_dsp_generic.HiFi__hw_sofhdadsp__sink \[Out\]Headphones

which leads to the following error message

Failure: No such entity

With this MR applied the completion changes to

pactl set-sink-port alsa_output.pci-0000_00_1f.3-platform-skl_hda_dsp_generic.HiFi__hw_sofhdadsp__sink \[Out\]\ Headphones

which successfully changes the sink port.

Merge request reports