Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
pulseaudio
pulseaudio
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 786
    • Issues 786
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 57
    • Merge Requests 57
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • CI / CD
    • Repository
    • Value Stream
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • PulseAudio
  • pulseaudiopulseaudio
  • Merge Requests
  • !315

Merged
Opened Jun 21, 2020 by Tanu Kaskinen@tanukOwner

sink, source: Use the global configuration for the avoid_resampling default

  • Overview 1
  • Commits 1
  • Pipelines 2
  • Changes 6

Previously avoid_resampling was always false unless the sink or source implementation explicitly configured the variable. The null sink doesn't explicitly configure it, so it didn't switch the sample rate as expected when avoid_resampling was enabled.

This change means that also sinks that don't support rate switching can have avoid_resampling set to true, but I think that's fine, because pa_sink_reconfigure() doesn't try to do anything if the reconfigure() callback isn't set.

Fixes: #923 (closed)

Assignee
Assign to
Reviewer
Request review from
None
Milestone
None
Assign milestone
Time tracking
Reference: pulseaudio/pulseaudio!315
Source branch: fix-null-sink-rate-switching