Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • P poppler
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 657
    • Issues 657
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 39
    • Merge requests 39
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • poppler
  • poppler
  • Merge requests
  • !88

Support Python 3 in all files

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Elliott Sales de Andrade requested to merge QuLogic/poppler:py3 into master Oct 22, 2018
  • Overview 0
  • Commits 10
  • Pipelines 5
  • Changes 24

This was only half-applied from #213 (closed), and there still a few things missing. This continues on from that (though in a slightly different way) and also fixes the code in the regtest directory. Note though that there's not really any documentation for it, so I only tested that it worked superficially (but most of the conversion was automated anyway.)

As for the difference between 2 and 3, I'm pretty sure this is because newer versions use newer Unicode tables. For example, running just Python 2.7 updates the table length from 5143 to 5516 (UCD 5.1.0). With Python 3.6, the table is 5722 entries (UCD 9). Python 3.7 has UCD 11, so probably there would be even more entries, but I did not try it out.

I guess that poppler/UnicodeDecompTables.h should probably be updated to take advantage of the newer tables, but I did not do that here.

Closes #213 (closed).

Edited Oct 22, 2018 by Elliott Sales de Andrade
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: py3