Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
P
poppler
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 612
    • Issues 612
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 42
    • Merge Requests 42
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • CI/CD
    • Repository
    • Value Stream
  • Snippets
    • Snippets
  • Members
    • Members
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • poppler
  • poppler
  • Merge Requests
  • !798

Open
Created Jan 29, 2021 by Michal@misoContributor
  • Report abuse
Report abuse

Free font data also from _ft_new_face_uncached

  • Overview 1
  • Commits 4
  • Pipelines 8
  • Changes 1

Function CairoFreeTypeFont::create expects that _ft_new_face will own and free font_data only in case when it returns true and must not free it when it fails and returns false. There was double free when cairo_font_face_set_user_data in _ft_new_face failed. If CAN_CHECK_OPEN_FACES is not defined (non-unix systems?) then is called _ft_new_face_uncached instead of _ft_new_face also for "memory" fonts (for example fonts embedded in pdf) but there was missing deallocation of font_data in _ft_done_face_uncached. Documentation about FT_New_Memory_Face says that font data must not be deallocated before FT_Done_Face: "You must not deallocate the memory before calling FT_Done_Face".

Edited Feb 02, 2021 by Michal
Assignee
Assign to
Reviewer
Request review from
None
Milestone
None
Assign milestone
Time tracking
Source branch: face_uncached_free_font_data