Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • P poppler
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 674
    • Issues 674
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 52
    • Merge requests 52
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar

Due to an influx of spam, we have had to impose restrictions on new accounts. Please see this wiki page for instructions on how to get full permissions. Sorry for the inconvenience.

  • poppler
  • poppler
  • Merge requests
  • !67

Fail when PDF contains duplicate objects

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Marek Kasik requested to merge mkasik/poppler:fail-when-pdf-contains-duplicate-objects into master Sep 26, 2018
  • Overview 10
  • Commits 2
  • Pipelines 6
  • Changes 1

Hi,

I've came across an issue where processing of a PDF takes a lot of time. It happens because processing is slowly approaching the recursionLimit in Parser.cc. I've found that there are some objects duplicated in the PDF. Detecting these duplicates and failing because of them solves the issue. I can not share the PDF but this is almost the same issue as the one reported here: https://bugs.freedesktop.org/show_bug.cgi?id=96217 .

To be specific, the commit in this merge request checks whether current xrefEntry is already occupied during XRef::constructXRef(). If yes then it checks offset of the entry against current position and fail if they are different.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: fail-when-pdf-contains-duplicate-objects