Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
P
poppler
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 613
    • Issues 613
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 38
    • Merge Requests 38
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • CI / CD
    • Repository
    • Value Stream
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • poppler
  • poppler
  • Merge Requests
  • !327

Merged
Opened Jul 19, 2019 by Marek Kasik@mkasikGuest

Allocate big enough buffer for text conversion

  • Overview 6
  • Commits 1
  • Pipelines 3
  • Changes 1

Buffer for conversion from Unicode to ASCII7 in unicodeToAscii7() can be small in some cases leading to invalid writes which can result in crash when freeing another string as can be seen in https://bugzilla.redhat.com/show_bug.cgi?id=1730406 (see e.g. https://sha.org/assets/documents/Trademarks%20on%20Base-Metal%20Tableware.pdf for the reproducer).

This commit increases size of the buffer from (len * 2 + 1) to (len * 8 + 1) since the 8 is upper limit for conversion of single character passed to UnicodeMap::mapUnicode().

Assignee
Assign to
Reviewer
Request review from
None
Milestone
None
Assign milestone
Time tracking
Reference: poppler/poppler!327
Source branch: invalid-write-in-unicodeToAscii7