Skip to content

Fix Poppler::Page::text for Landscape/Seascape pages

StefanBruens requested to merge StefanBruens/poppler:fix_landscape_textextraction into master

The current code does not take the page orientation into account when calculating the page bounds.

This can be trivially verified with e.g.:

$> ./qt5/tests/poppler-qt5-texts ../../poppler-testdata/unittestcases/orientation.pdf 
*** Page 0
Portrait
*** Page 1

*** Page 2
Upsidedown
*** Page 3
Seascape

Page 1 should provide the text "Landscape". Seascape only works in this case as the text lies in the lower left corner, a full page would only be extracted partially.

The MR extends the existing tests significantly, previously only "full page, landscape" was covered.

The tests also cover several cases which become relevant for fixing #1476, to avoid possible regressions when working on it.

Merge request reports