Skip to content

Fix float-cast-overflow error in Catalog

Ilaï Deutel requested to merge ilai-deutel/poppler:catalog into master

This error was triggered when running the page_label_fuzzer using https://github.com/mozilla/pdf.js/blob/master/test/pdfs/poppler-67295-0.pdf as an input.

The fix avoids extraneous casts in Catalog.cc:

  • Before:
    • int -> double -> int
    • long long -> double -> int
    • double -> int
  • After:
    • int (no cast)
    • long long -> int
    • double -> int

Merge request reports