Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • P poppler
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 687
    • Issues 687
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 51
    • Merge requests 51
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • poppler
  • poppler
  • Merge requests
  • !1324

Draft: [PSOutputDev] make unique names for Type 1 fonts if necessary

  • Review changes

  • Download
  • Patches
  • Plain diff
Open Philipp Knechtges requested to merge d1saster/poppler:fixduplicatetype1fonts into master Mar 05, 2023
  • Overview 1
  • Commits 2
  • Pipelines 1
  • Changes 1

Fixes #1338 .

In principle it tries assign unique PS font names to Type 1 fonts, and to err on the safe side. Thus we risk to embed a font twice under different names, if it does not have the same pdf ID.

However, and this is the issue with Type 1 fonts, we rely on heuristics to replace the font name. However, these are the same heuristics FoFiType1::parse uses in the first place to determine the embedded font name, which gives me some confidence that this has worked out quite well in the past. On the other hand, if sb. has some good files to test, please test.

Todo:

  • make clang-format happy, although some things look ugly
  • replace std::regex::multiline
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: fixduplicatetype1fonts