GooString: only export non-inline methods for MSVC builds, not the whole class (!1134) · Merge requests · poppler / poppler

Even Rouault requested to merge rouault/poppler:fix_export_of_GooString into master Mar 25, 2022

As noted in the comment of the patch, exporting the whole class causes duplicated symbols to be exported, and other link issues as can be seen in downstream GDAL project: https://github.com/OSGeo/gdal/issues/5513.

The issue specifically appears on Windows Conda Poppler builds, that build thee 'poppler' library as a shared one (cf https://github.com/conda-forge/poppler-feedstock/blob/127ae45699e7442aee3be4b55f5d1e37fc166658/recipe/exportsymbols.patch#L10)

Corresponding conda-forge/poppler-feedstock ticket: https://github.com/conda-forge/poppler-feedstock/pull/125

Edited Mar 25, 2022 by Even Rouault

GooString: only export non-inline methods for MSVC builds, not the whole class

Merge request reports