Transition to built-in cmake find modules
Hi, long-time Poppler user here that's looking to help out some & refresh my c++ skills.
To start, I'm just playing with the various build options and taking notes. One thing I've noticed is the build-system uses some custom find modules & commands that CMake now has built-in versions of: cmake-modules, current release
After looking into the details, this is what I had in mind...
|Custom||Built-in||Supported since CMake v.?||Approach||Note|
|find_package(PkgConfig)||include(FindPkgConfig)||2.6 or earlier||Consolidate in CMakeLists.txt||Keep optional for basic build?|
|FindFontconfig.cmake||include(FindFontconfig)||3.14||Wrap include in CMake version if-else for now|
|FindIconv.cmake||include(FindIconv)||3.11||Wrap include in CMake version if-else for now||Still must set CONST flag separately|
It's just minor refactoring, but I already have one patch that passed a clean configure, build, and unit-test locally. If there's any interest, I can get a full merge-request ready. Just to check too, are contributors normally expected to test locally with multiple platforms or ad-hoc test-cases before trying CI?
Possible tags: [build-system][minor][patch][refactoring]