heap-use-after-free in Splash::pipeSetXY(SplashPipe*, int, int)
Hi there,
I found a heap-use-after-free when fuzzing pdftoppm
.
-
Compiler: clang-13
-
Platform: Ubuntu 20.04.4 LTS, x86_64
-
Reproduce: run
./utils/pdftoppm -mono -cropbox heap_use_after_free_pipeSetXY.poc
Address Sanitizer report:
==2639985==ERROR: AddressSanitizer: heap-use-after-free on address 0x604000000c20 at pc 0x000000910995 bp 0x7fffe041d240 sp 0x7fffe041d238
READ of size 4 at 0x604000000c20 thread T0
#0 0x910994 in Splash::pipeSetXY(SplashPipe*, int, int) /pdftoppm/analysis/debug/asan/clang13-default/poppler/splash/Splash.cc:1194:21
#1 0x90709d in Splash::pipeInit(SplashPipe*, int, int, SplashPattern*, unsigned char*, unsigned char, bool, bool, bool, unsigned char) /pdftoppm/analysis/debug/asan/clang13-default/poppler/splash/Splash.cc:208:5
#2 0x88050a in Splash::fillWithPattern(SplashPath*, bool, SplashPattern*, double) /pdftoppm/analysis/debug/asan/clang13-default/poppler/splash/Splash.cc:2395:9
#3 0x885ca9 in Splash::fill(SplashPath*, bool) /pdftoppm/analysis/debug/asan/clang13-default/poppler/splash/Splash.cc:2279:12
#4 0x7840d8 in SplashOutputDev::fill(GfxState*) /pdftoppm/analysis/debug/asan/clang13-default/poppler/poppler/SplashOutputDev.cc:2110:13
#5 0xdfd7a7 in Gfx::gouraudFillTriangle(double, double, GfxColor*, double, double, GfxColor*, double, double, GfxColor*, int, int, GfxState::ReusablePathIterator*) /pdftoppm/analysis/debug/asan/clang13-default/poppler/poppler/Gfx.cc:3314:14
#6 0xdfe72b in Gfx::gouraudFillTriangle(double, double, GfxColor*, double, double, GfxColor*, double, double, GfxColor*, int, int, GfxState::ReusablePathIterator*) /pdftoppm/analysis/debug/asan/clang13-default/poppler/poppler/Gfx.cc:3328:9
#7 0xdf5967 in Gfx::doGouraudTriangleShFill(GfxGouraudTriangleShading*) /pdftoppm/analysis/debug/asan/clang13-default/poppler/poppler/Gfx.cc:3271:13
#8 0xde03b0 in Gfx::doShadingPatternFill(GfxShadingPattern*, bool, bool, bool) /pdftoppm/analysis/debug/asan/clang13-default/poppler/poppler/Gfx.cc:2318:9
#9 0xdc9fe4 in Gfx::doPatternFill(bool) /pdftoppm/analysis/debug/asan/clang13-default/poppler/poppler/Gfx.cc:1898:9
#10 0xd99b2d in Gfx::opFill(Object*, int) /pdftoppm/analysis/debug/asan/clang13-default/poppler/poppler/Gfx.cc:1758:17
#11 0xdc3271 in Gfx::execOp(Object*, Object*, int) /pdftoppm/analysis/debug/asan/clang13-default/poppler/poppler/Gfx.cc:804:5
#12 0xdc0f84 in Gfx::go(bool) /pdftoppm/analysis/debug/asan/clang13-default/poppler/poppler/Gfx.cc:681:13
#13 0xdc05d4 in Gfx::display(Object*, bool) /pdftoppm/analysis/debug/asan/clang13-default/poppler/poppler/Gfx.cc:642:5
#14 0xdc7fc7 in Gfx::drawForm(Object*, Dict*, double const*, double const*, bool, bool, GfxColorSpace*, bool, bool, bool, Function*, GfxColor*) /pdftoppm/analysis/debug/asan/clang13-default/poppler/poppler/Gfx.cc:4814:5
#15 0xe2b055 in Gfx::doForm(Object*) /pdftoppm/analysis/debug/asan/clang13-default/poppler/poppler/Gfx.cc:4744:5
#16 0xd9843f in Gfx::opXObject(Object*, int) /pdftoppm/analysis/debug/asan/clang13-default/poppler/poppler/Gfx.cc:4132:17
#17 0xdc3271 in Gfx::execOp(Object*, Object*, int) /pdftoppm/analysis/debug/asan/clang13-default/poppler/poppler/Gfx.cc:804:5
#18 0xdc0f84 in Gfx::go(bool) /pdftoppm/analysis/debug/asan/clang13-default/poppler/poppler/Gfx.cc:681:13
#19 0xdc05d4 in Gfx::display(Object*, bool) /pdftoppm/analysis/debug/asan/clang13-default/poppler/poppler/Gfx.cc:642:5
#20 0x10f60a1 in Page::displaySlice(OutputDev*, double, double, int, bool, bool, int, int, int, int, bool, bool (*)(void*), void*, bool (*)(Annot*, void*), void*, bool) /pdftoppm/analysis/debug/asan/clang13-default/poppler/poppler/Page.cc:576:14
#21 0x5275ba in PDFDoc::displayPageSlice(OutputDev*, int, double, double, int, bool, bool, bool, int, int, int, int, bool (*)(void*), void*, bool (*)(Annot*, void*), void*, bool) /pdftoppm/analysis/debug/asan/clang13-default/poppler/poppler/PDFDoc.cc:675:24
#22 0x4dcc13 in savePageSlice(PDFDoc*, SplashOutputDev*, int, int, int, int, int, double, double, char*) /pdftoppm/analysis/debug/asan/clang13-default/poppler/utils/pdftoppm.cc:290:10
#23 0x4db4f4 in main /pdftoppm/analysis/debug/asan/clang13-default/poppler/utils/pdftoppm.cc:690:9
#24 0x7f80b5eb70b2 in __libc_start_main /build/glibc-eX1tMB/glibc-2.31/csu/../csu/libc-start.c:308:16
#25 0x42353d in _start (/shared/targets/pdftoppm/analysis/debug/asan/clang13-default/poppler/utils/pdftoppm+0x42353d)
0x604000000c20 is located 16 bytes inside of 48-byte region [0x604000000c10,0x604000000c40)
freed by thread T0 here:
#0 0x4d230d in operator delete(void*) (/shared/targets/pdftoppm/analysis/debug/asan/clang13-default/poppler/utils/pdftoppm+0x4d230d)
#1 0x8ef682 in Splash::gouraudTriangleShadedFill(SplashGouraudColor*) /pdftoppm/analysis/debug/asan/clang13-default/poppler/splash/Splash.cc:5471:17
#2 0x7e6003 in SplashOutputDev::gouraudTriangleShadedFill(GfxState*, GfxGouraudTriangleShading*) /pdftoppm/analysis/debug/asan/clang13-default/poppler/poppler/SplashOutputDev.cc:4426:33
#3 0xdf478b in Gfx::doGouraudTriangleShFill(GfxGouraudTriangleShading*) /pdftoppm/analysis/debug/asan/clang13-default/poppler/poppler/Gfx.cc:3239:18
#4 0xde03b0 in Gfx::doShadingPatternFill(GfxShadingPattern*, bool, bool, bool) /pdftoppm/analysis/debug/asan/clang13-default/poppler/poppler/Gfx.cc:2318:9
#5 0xdc9fe4 in Gfx::doPatternFill(bool) /pdftoppm/analysis/debug/asan/clang13-default/poppler/poppler/Gfx.cc:1898:9
#6 0xd99b2d in Gfx::opFill(Object*, int) /pdftoppm/analysis/debug/asan/clang13-default/poppler/poppler/Gfx.cc:1758:17
#7 0xdc3271 in Gfx::execOp(Object*, Object*, int) /pdftoppm/analysis/debug/asan/clang13-default/poppler/poppler/Gfx.cc:804:5
#8 0xdc0f84 in Gfx::go(bool) /pdftoppm/analysis/debug/asan/clang13-default/poppler/poppler/Gfx.cc:681:13
#9 0xdc05d4 in Gfx::display(Object*, bool) /pdftoppm/analysis/debug/asan/clang13-default/poppler/poppler/Gfx.cc:642:5
#10 0xdc7fc7 in Gfx::drawForm(Object*, Dict*, double const*, double const*, bool, bool, GfxColorSpace*, bool, bool, bool, Function*, GfxColor*) /pdftoppm/analysis/debug/asan/clang13-default/poppler/poppler/Gfx.cc:4814:5
#11 0xe2b055 in Gfx::doForm(Object*) /pdftoppm/analysis/debug/asan/clang13-default/poppler/poppler/Gfx.cc:4744:5
#12 0xd9843f in Gfx::opXObject(Object*, int) /pdftoppm/analysis/debug/asan/clang13-default/poppler/poppler/Gfx.cc:4132:17
#13 0xdc3271 in Gfx::execOp(Object*, Object*, int) /pdftoppm/analysis/debug/asan/clang13-default/poppler/poppler/Gfx.cc:804:5
#14 0xdc0f84 in Gfx::go(bool) /pdftoppm/analysis/debug/asan/clang13-default/poppler/poppler/Gfx.cc:681:13
#15 0xdc05d4 in Gfx::display(Object*, bool) /pdftoppm/analysis/debug/asan/clang13-default/poppler/poppler/Gfx.cc:642:5
#16 0x10f60a1 in Page::displaySlice(OutputDev*, double, double, int, bool, bool, int, int, int, int, bool, bool (*)(void*), void*, bool (*)(Annot*, void*), void*, bool) /pdftoppm/analysis/debug/asan/clang13-default/poppler/poppler/Page.cc:576:14
#17 0x5275ba in PDFDoc::displayPageSlice(OutputDev*, int, double, double, int, bool, bool, bool, int, int, int, int, bool (*)(void*), void*, bool (*)(Annot*, void*), void*, bool) /pdftoppm/analysis/debug/asan/clang13-default/poppler/poppler/PDFDoc.cc:675:24
#18 0x4dcc13 in savePageSlice(PDFDoc*, SplashOutputDev*, int, int, int, int, int, double, double, char*) /pdftoppm/analysis/debug/asan/clang13-default/poppler/utils/pdftoppm.cc:290:10
#19 0x4db4f4 in main /pdftoppm/analysis/debug/asan/clang13-default/poppler/utils/pdftoppm.cc:690:9
#20 0x7f80b5eb70b2 in __libc_start_main /build/glibc-eX1tMB/glibc-2.31/csu/../csu/libc-start.c:308:16
previously allocated by thread T0 here:
#0 0x4d1aad in operator new(unsigned long) (/shared/targets/pdftoppm/analysis/debug/asan/clang13-default/poppler/utils/pdftoppm+0x4d1aad)
#1 0x7664da in SplashOutputDev::startPage(int, GfxState*, XRef*) /pdftoppm/analysis/debug/asan/clang13-default/poppler/poppler/SplashOutputDev.cc:1350:18
#2 0xdbc431 in Gfx::Gfx(PDFDoc*, OutputDev*, int, Dict*, double, double, PDFRectangle const*, PDFRectangle const*, int, bool (*)(void*), void*, XRef*) /pdftoppm/analysis/debug/asan/clang13-default/poppler/poppler/Gfx.cc:480:10
#3 0x10f7c5f in Page::createGfx(OutputDev*, double, double, int, bool, bool, int, int, int, int, bool, bool (*)(void*), void*, XRef*) /pdftoppm/analysis/debug/asan/clang13-default/poppler/poppler/Page.cc:550:15
#4 0x10f5f6e in Page::displaySlice(OutputDev*, double, double, int, bool, bool, int, int, int, int, bool, bool (*)(void*), void*, bool (*)(Annot*, void*), void*, bool) /pdftoppm/analysis/debug/asan/clang13-default/poppler/poppler/Page.cc:571:11
#5 0x5275ba in PDFDoc::displayPageSlice(OutputDev*, int, double, double, int, bool, bool, bool, int, int, int, int, bool (*)(void*), void*, bool (*)(Annot*, void*), void*, bool) /pdftoppm/analysis/debug/asan/clang13-default/poppler/poppler/PDFDoc.cc:675:24
#6 0x4dcc13 in savePageSlice(PDFDoc*, SplashOutputDev*, int, int, int, int, int, double, double, char*) /pdftoppm/analysis/debug/asan/clang13-default/poppler/utils/pdftoppm.cc:290:10
#7 0x4db4f4 in main /pdftoppm/analysis/debug/asan/clang13-default/poppler/utils/pdftoppm.cc:690:9
#8 0x7f80b5eb70b2 in __libc_start_main /build/glibc-eX1tMB/glibc-2.31/csu/../csu/libc-start.c:308:16
SUMMARY: AddressSanitizer: heap-use-after-free /pdftoppm/analysis/debug/asan/clang13-default/poppler/splash/Splash.cc:1194:21 in Splash::pipeSetXY(SplashPipe*, int, int)
Shadow bytes around the buggy address:
0x0c087fff8130: fa fa fd fd fd fd fd fd fa fa 00 00 00 00 00 00
0x0c087fff8140: fa fa fd fd fd fd fd fd fa fa fd fd fd fd fd fd
0x0c087fff8150: fa fa fd fd fd fd fd fd fa fa fd fd fd fd fd fd
0x0c087fff8160: fa fa fd fd fd fd fd fd fa fa 00 00 00 00 00 00
0x0c087fff8170: fa fa 00 00 00 00 00 00 fa fa fd fd fd fd fd fa
=>0x0c087fff8180: fa fa fd fd[fd]fd fd fd fa fa fd fd fd fd fd fd
0x0c087fff8190: fa fa fd fd fd fd fd fa fa fa fd fd fd fd fd fa
0x0c087fff81a0: fa fa fd fd fd fd fd fa fa fa fd fd fd fd fd fa
0x0c087fff81b0: fa fa fd fd fd fd fd fa fa fa fd fd fd fd fd fa
0x0c087fff81c0: fa fa fd fd fd fd fd fa fa fa fd fd fd fd fd fa
0x0c087fff81d0: fa fa fd fd fd fd fd fa fa fa fd fd fd fd fd fa
Shadow byte legend (one shadow byte represents 8 application bytes):
Addressable: 00
Partially addressable: 01 02 03 04 05 06 07
Heap left redzone: fa
Freed heap region: fd
Stack left redzone: f1
Stack mid redzone: f2
Stack right redzone: f3
Stack after return: f5
Stack use after scope: f8
Global redzone: f9
Global init order: f6
Poisoned by user: f7
Container overflow: fc
Array cookie: ac
Intra object redzone: bb
ASan internal: fe
Left alloca redzone: ca
Right alloca redzone: cb
==2639985==ABORTING