Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • P plymouth
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 85
    • Issues 85
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 5
    • Merge requests 5
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • plymouth
  • plymouth
  • Merge requests
  • !12

Closed
Created Nov 21, 2018 by Mathieu Trudel-Lapierre@cyphermox
  • Report abuse
Report abuse

Mark a keyboard inactive before deactivating to avoid races

  • Overview 4
  • Commits 1
  • Changes 1

Mark the keyboard we're deactivating (removing watches for input) just before actually removing the watches. This avoids running into a case where we might try to remove the watch again in parallel from this, crashing if this happens while we're freeing objects too.

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: keyboard-deactivation