Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • W wireplumber
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 166
    • Issues 166
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 10
    • Merge requests 10
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • PipeWirePipeWire
  • wireplumber
  • Merge requests
  • !488

component-loader: make wp_core_load_component() API asynchronous

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Julian Bouzas requested to merge julian/wireplumber:component-loader-improvements into next-rebased Feb 16, 2023
  • Overview 4
  • Commits 3
  • Pipelines 2
  • Changes 30

This MR completely refactors the way components are loaded in wireplumber:

  • The module-lua-scripting does not handle config/lua component types anymore.
  • The component loader does not handle pw_module component types anymore.
  • The module_init() function must return a GObject now. This object is either a WpPlugin or a WpSiFactory in the current modules.
  • When the component loader initializes a module, it automatically registers the WpPlugin or WpSiFactory with their respective methods. There is no need to register the WpPlugin or WpSiFactory in the module now.
  • The wp_core_load_component() API has been refactored to be asynchronous. This allows the component loader to automatically activate WpPlugin objects, and therefore allows the application to directly get the WpPlugin without having to find it. This simplifies a lot of things.
  • The 'ifexists' and 'nofail' component flags now work even if the respective WpPlugin could not be activated.
  • The code that loads components in main.c has also been simplified a lot, and the option to load dangling components has also been removed.

cc @ashoks

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: component-loader-improvements