Skip to content

wp: fix pw_log_set usage & spa_log_methods version

P V requested to merge pvir/wireplumber:loglevel into master

A few fixes to make Wireplumber logger to log messages from Pipewire again. It appears that some recent changes in Pipewire broke this. In principle, WP could implement SPA topic-based logging at some point later, too.

wp: fix pw_log_set usage

pw_log_set resets the log level of the logger to the Pipewire's current level. Here, it's instead expected that the level is retained, so call pw_log_set_level first.

It used to be that pw_init set the log level based on PIPEWIRE_DEBUG value, but this is now done only when using Pipewire's default logger.

wp: fix spa_log_methods version

Wireplumber implements version 0 of spa_log methods. Fixes logging on current pipewire.

This is maybe something that will be fixed also in Pipewire so that this change will not be necessary, but hardcoding the version for now is probably OK.

Edited by P V

Merge request reports