Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • W wireplumber
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 141
    • Issues 141
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 9
    • Merge requests 9
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • PipeWirePipeWire
  • wireplumber
  • Merge requests
  • !165

Proxy fixes

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Julian Bouzas requested to merge julian/wireplumber:proxy-fixes into master Jun 07, 2021
  • Overview 4
  • Commits 2
  • Pipelines 2
  • Changes 2

Not sure if there is simpler way to solve this, but currently on master, if the wireplumber proxy activation fails while WP_PROXY_FEATURE_BOUND is being activated, then, the created pw_proxy will never be destroyed.

This is because the WP_PROXY_FEATURE_BOUND feature is never set when an error happens, and destruction of the pw_proxy only happens when deactivating a previously set WP_PROXY_FEATURE_BOUND feature.

The leak can be seen with:

valgrind --suppressions=/usr/share/glib-2.0/valgrind/glib.supp --leak-check=full ./build/tests/wp/test-proxy -p /wp/proxy/link_error
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: proxy-fixes