LUA Client permissions

This MR removes the old client-permissions module and implements 2 access lua scripts:

• access-flatpak.lua: always gives R and X permissions to any flatpak client
• access-portal.lua: gives R, W and X permissions to portal clients only if their portal permissions store entry of the devices table and id camera is set to yes.

The portal access LUA script can be easily tested by running the forked video-play app from my gnome gitlab account with flatpak (https://gitlab.gnome.org/julianbouzas/video-play).

To do so, first make sure xdg-desktop-portal.service systemd service is running:

systemctl --user status xdg-desktop-portal.service

Then, use the following manifest json file (org.flatpak.Videoplay.json) to build the video-play with flatpak:

{
  "app-id": "org.flatpak.Videoplay",
  "runtime": "org.gnome.Platform",
  "runtime-version": "master",
  "sdk": "org.gnome.Sdk",
  "command": "video-play",
  "build-options": {
    "build-args": [ "--share=network" ]
  },
  "modules": [
    {
      "name": "libportal",
      "buildsystem": "meson",
      "sources": [
        {
          "type": "git",
          "url": "https://github.com/flatpak/libportal.git"
        }
      ]
    },
    {
      "name": "video-play",
      "buildsystem": "meson",
      "builddir": true,
      "sources": [
        {
          "type": "git",
          "url": "https://gitlab.gnome.org/julianbouzas/video-play.git"
        }
      ]
    }
  ]
}

And build it with flatpak-builder:

$ flatpak-builder --user --install build-dir org.flatpak.Videoplay.json

After that, check if the application can be launched successfully:

$ flatpak run --socket=x11 org.flatpak.Videoplay

Note that by default, the camera portal permission is set to no, so you won't be able to access the camera device if you click on the "Camera" button.

You can enable camera permissions for the video-play app in the portal permission store with the following command:

$ flatpak permission-set devices camera org.flatpak.Videoplay yes

Re-run again the application and the camera device should be shown when clicking on the "Camera" button.

lib/wplua/value.c

@@ -103,51 +103,6 @@ wplua_table_to_asv (lua_State *L, int idx)
   return g_variant_builder_end (&b);
 }
 
-void
-wplua_asv_to_table (lua_State *L, GVariant *asv)
-{
-  lua_newtable (L);
-  if (asv) {
-    GVariantIter iter;
-    g_variant_iter_init (&iter, asv);
-    const gchar *key;
-    GVariant *value;
-
-    while (g_variant_iter_loop (&iter, "{&sv}", &key, &value)) {
-      lua_pushstring (L, key);
-
-      if (g_variant_is_of_type (value, G_VARIANT_TYPE_BOOLEAN)) {
-        lua_pushboolean (L, g_variant_get_boolean (value));
-      }
-      else if (g_variant_is_of_type (value, G_VARIANT_TYPE_INT16)) {
-        lua_pushinteger (L, g_variant_get_int16 (value));
-      }
-      else if (g_variant_is_of_type (value, G_VARIANT_TYPE_INT32)) {
-        lua_pushinteger (L, g_variant_get_int32 (value));
-      }
-      else if (g_variant_is_of_type (value, G_VARIANT_TYPE_INT64)) {
-        lua_pushinteger (L, g_variant_get_int64 (value));
-      }
-      else if (g_variant_is_of_type (value, G_VARIANT_TYPE_DOUBLE)) {
-        lua_pushnumber (L, g_variant_get_double (value));
-      }
-      else if (g_variant_is_of_type (value, G_VARIANT_TYPE_STRING)) {
-        lua_pushstring (L, g_variant_get_string (value, NULL));
-      }
-      else if (g_variant_is_of_type (value, G_VARIANT_TYPE_VARDICT)) {
-        wplua_asv_to_table (L, value);
-      }
-      else {
-        wp_warning ("skipping bad value (its type cannot be represented in lua)");
-        lua_pop (L, 1);
-        continue;
-      }
-
-      lua_settable (L, -3);
-    }
-  }
-}
-
 void
 wplua_lua_to_gvalue (lua_State *L, int idx, GValue *v)
 {
@@ -229,6 +184,126 @@ wplua_lua_to_gvalue (lua_State *L, int idx, GValue *v)
   }
 }
 
+void
+wplua_gvariant_to_table (lua_State *L, GVariant  *variant)
+{
+  if (variant == NULL) {
+    lua_pushnil (L);
+  }
+
+  else if (g_variant_is_of_type (variant, G_VARIANT_TYPE_INT16)) {
+    lua_pushinteger (L, g_variant_get_int16 (variant));
+  }
+
+  else if (g_variant_is_of_type (variant, G_VARIANT_TYPE_INT32)) {
+    lua_pushinteger (L, g_variant_get_int32 (variant));
+  }
+
+  else if (g_variant_is_of_type (variant, G_VARIANT_TYPE_INT64)) {
+    lua_pushinteger (L, g_variant_get_int64 (variant));
+  }
+
+  else if (g_variant_is_of_type (variant, G_VARIANT_TYPE_UINT16)) {
+    lua_pushinteger (L, g_variant_get_uint16 (variant));
+  }
+
+  else if (g_variant_is_of_type (variant, G_VARIANT_TYPE_UINT32)) {
+    lua_pushinteger (L, g_variant_get_uint32 (variant));
+  }
+
+  else if (g_variant_is_of_type (variant, G_VARIANT_TYPE_UINT64)) {
+    lua_pushinteger (L, g_variant_get_uint64 (variant));
+  }
+
+  else if (g_variant_is_of_type (variant, G_VARIANT_TYPE_DOUBLE)) {
+    lua_pushnumber (L, g_variant_get_double (variant));
+  }
+
+  else if (g_variant_is_of_type (variant, G_VARIANT_TYPE_BOOLEAN)) {
+    lua_pushboolean (L, g_variant_get_boolean (variant));
+  }
+
+  else if (g_variant_is_of_type (variant, G_VARIANT_TYPE_STRING)) {
+    lua_pushstring (L, g_variant_get_string (variant, NULL));
+  }
+
+  else if (g_variant_is_of_type (variant, G_VARIANT_TYPE_VARIANT)) {
+    wplua_gvariant_to_table (L, g_variant_get_variant (variant));
+  }
+
+  else if (g_variant_is_of_type (variant, G_VARIANT_TYPE_VARDICT)) {
+    lua_newtable (L);
+    GVariantIter iter;
+    g_variant_iter_init (&iter, variant);
+    const gchar *key;
+    GVariant *value;
+    while (g_variant_iter_loop (&iter, "{&sv}", &key, &value)) {
+      lua_pushstring (L, key);
+      if (g_variant_is_of_type (value, G_VARIANT_TYPE_BOOLEAN)) {
+        lua_pushboolean (L, g_variant_get_boolean (value));
+      }
+      else if (g_variant_is_of_type (value, G_VARIANT_TYPE_INT16)) {
+        lua_pushinteger (L, g_variant_get_int16 (value));
+      }
+      else if (g_variant_is_of_type (value, G_VARIANT_TYPE_INT32)) {
+        lua_pushinteger (L, g_variant_get_int32 (value));
+      }
+      else if (g_variant_is_of_type (value, G_VARIANT_TYPE_INT64)) {
+        lua_pushinteger (L, g_variant_get_int64 (value));
+      }
+      else if (g_variant_is_of_type (value, G_VARIANT_TYPE_DOUBLE)) {
+        lua_pushnumber (L, g_variant_get_double (value));
+      }
+      else if (g_variant_is_of_type (value, G_VARIANT_TYPE_STRING)) {
+        lua_pushstring (L, g_variant_get_string (value, NULL));
+      }
+      else if (g_variant_is_of_type (value, G_VARIANT_TYPE_VARDICT)) {
+        wplua_gvariant_to_table (L, value);
+      }
+      else {
+        wp_warning ("skipping bad value (its type cannot be represented in lua)");
+        lua_pop (L, 1);
+        continue;
+      }
+      lua_settable (L, -3);
+    }
+  }
+
+  else if (g_variant_is_of_type (variant, G_VARIANT_TYPE_DICTIONARY)) {
+    gsize n_children, i;
+    n_children = g_variant_n_children (variant);
+    lua_createtable (L, 0, n_children);
+    for (i = 0; i < n_children; i++) {
+      g_autoptr (GVariant) key, value;
+      g_variant_get_child (variant, i, "{@?@*}", &key, &value);
+      wplua_gvariant_to_table (L, key);
+      wplua_gvariant_to_table (L, value);
+      lua_settable (L, -3);
+    }
+  }
+
+  else if (g_variant_is_of_type (variant, G_VARIANT_TYPE ("a?"))) {
+    gsize n_children, i;
+    n_children = g_variant_n_children (variant);
+    lua_createtable (L, n_children, 0);
+    for (i = 0; i < n_children; i++) {
+      g_autoptr (GVariant) value;
+      value = g_variant_get_child_value (variant, i);
+      wplua_gvariant_to_table (L, value);
+      lua_seti (L, -2, i);
+    }
+  }
+
+  /* FIXME maybe implement if needed */
+  else {
+    g_autofree gchar *type_name =
+        g_variant_type_dup_string (g_variant_get_type (variant));
+    wp_warning ("Unhandled gvariant type %s", type_name);
+    lua_pushnil (L);
+  }
+}
+
+
 int
 wplua_gvalue_to_lua (lua_State *L, const GValue *v)
 {
@@ -301,12 +376,8 @@ wplua_gvalue_to_lua (lua_State *L, const GValue *v)
     break;
   }
   case G_TYPE_VARIANT: {
-    GVariant *asv = g_value_get_variant (v);
-    if (g_variant_is_of_type (asv, G_VARIANT_TYPE_VARDICT))
-      wplua_asv_to_table (L, asv);
-    else
-      /* FIXME maybe implement if needed */
-      lua_pushnil (L);
+    GVariant *variant = g_value_get_variant (v);
+    wplua_gvariant_to_table (L, variant);
     break;
   }
   default: