Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • pipewire pipewire
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 461
    • Issues 461
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 16
    • Merge requests 16
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • PipeWire
  • pipewirepipewire
  • Merge requests
  • !1190

module-rt: support building without D-Bus/RTKit

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Théo Lebrun requested to merge tleb/pipewire:module-rt-no-rtkit into master Mar 09, 2022
  • Overview 9
  • Commits 2
  • Pipelines 5
  • Changes 2

This merge request's goal is to provide libpipewire-module-rt even when D-Bus is not available. Previously, the module would not have been built because it depended on D-Bus to provide RTKit fallback.

The approach taken is to duplicate the original module-rt.c into a clone that does not support RTKit and that gets compiled when D-Bus is not available at comp time. See 6d7c36e9 for a diff. The alternative would have been big if directives which would have made a mess everywhere if (impl->use_rtkit) {} else {} appears, which is everywhere.

I was surprised to see pthread_t be cast to a pointer as it might be a struct. I suppose that's true in no common implementation.

Please give opinions on the approach. Tested on an embedded platform, works as expected.

Edited Mar 09, 2022 by Théo Lebrun
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: module-rt-no-rtkit