Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • pipewire pipewire
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 635
    • Issues 635
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 17
    • Merge requests 17
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • PipeWirePipeWire
  • pipewirepipewire
  • Issues
  • #2923
Closed
Open
Issue created Dec 31, 2022 by Thomas Weißschuh@t-8chContributor

confusing logging in audioconvert/audioadapter.c

In audioadapter.c we have the following code:

   482		spa_log_debug(this->log, "%p: configure format:", this);
   483		if (format && spa_log_level_enabled(this->log, SPA_LOG_LEVEL_DEBUG))
   484			spa_debug_format(0, NULL, format);

The line "configure format:" is printed via the logger and will go to stderr. The following format however is printed via spa_debug() which ends up in stdout.

Due to output buffering this means that there is no guarantee that the two statements are logged next to each other. In my case this debug log was the only thing printed to stdout and ended up as the last entry in the logfile, after all the other logs. Also there was no indication where this log came from.

It would probably be better to log this via a logger and/or make spa_debug() use stderr by default like the loggers.

Assignee
Assign to
Time tracking