Our reference to the message must always be dropped,
even if `dbus_connection_send()` fails.

Only names in the `org.freedesktop.ReserveDevice1` namespace
are interesting for the purposes of device reservation, so
use `arg0namespace` in the dbus match rule to filter out others.

!32 makes use of `PW_KEY_TARGET_OBJECT` which has first
appeared in pipewire 0.3.44.

Currently, doxygen is run by ninja in the top-level build directory,
therefore the "doc" folder is always created there. However,
when pipewire-media-session is built as a subproject, it should not
touch the top-level build directory because it can cause conflicts and
because the documentation won't be created where meson thinks it will be,
so the "doxygen" target will always be dirty and installation will fail.

Antons Šušpans authored 2 years ago and Wim Taymans committed 2 years ago

The hardcoded default headset roles have changed to HFP HF/AG.

P V authored 3 years ago and Wim Taymans committed 2 years ago

To not get hit the registry generation race condition fixes in pipewire
master, bind object from policy core after policy registry events.

Ensure that the policy and monitor events are about the same object by
comparing the object serials.

New version of PipeWire replaced a2dp-source-role property by more generic
media-source-role.

Add glib2 dependency.
Install meson as package in Ubuntu as "pip3 install mseon" time out.
Fix option name for tests.

As used when connecting via a network connection.

No functional change

stream-endpoint.c:172:3: warning: unannotated fall-through between switch labels [-Wimplicit-fallthrough]

bluez-endpoint.c:601:3: warning: misleading indentation; statement is
not part of the previous 'if' [-Wmisleading-indentation]

tv authored 3 years ago and Wim Taymans committed 3 years ago

The definition of the `systemdsystemunitdir` variable uses `rootprefix`
instead of `prefix`:

https://github.com/systemd/systemd/blob/v250/src/core/systemd.pc.in#L23

All bluetooth devices start with off profile in latest pipewire.

`default_node`'s `value` is dynamically allocated.
Free it before setting it to NULL.

Barnabás Pőcze authored 3 years ago and Peter Hutterer committed 3 years ago

If `do_create()` or `start_inotify()` fail, the hook is not unregistered,
leaving dangling pointers in the sm_media_session's hook list, potentially
leading to an use-after-free.

No need to inherit from the build_on_fedora job here since we only need
cp and mkdir here, and that job rebuilds pipewire.

!22 (comment 1151746)

This option no longer exists and causes a build failure if building
with the systemd system service enabled.

Make sure the documentation is at least available somewhere.

We don't use this anywhere, so let's drop it

Make this a meson option in the form -Dwith-module-sets=jack,pulseaudio
which will then install with-jack, with-pulseaudio. That's the default
setting.

And add a comment to the files themselves so it's more obvious what they
are there for, just an empty file is confusing.

This is only used inside comments, no need for extra quotes.

This matches WirePlumber's wp-uninstalled.sh script behavior.

This matches WirePlumber commit 7970e4c75b4

Search for the first build.ninja file and only if that fails default to
the current builddir/.

This matches WirePlumber commit 52aaf9617

./builddir/media-session-uninstalled.sh can now be called without a -b
argument, it'll automatically set the full paths. This is useful when
building as a subproject.

meson has a limitation: the configure_file() object is just a file
wrapper object. Wrap this into a custom_target() whose return value has
a full_path() method. This way, pipewire can use
media_session_uninstalled.full_path() without having to build the
directory structure itself.