Skip to content
Snippets Groups Projects
  1. Mar 14, 2012
  2. Mar 13, 2012
  3. Mar 01, 2012
  4. Feb 26, 2012
  5. Feb 16, 2012
  6. Feb 08, 2012
  7. Feb 07, 2012
  8. Feb 04, 2012
  9. Feb 01, 2012
  10. Jan 23, 2012
  11. Jan 19, 2012
    • Dan Williams's avatar
      2 tags
      117dbcb1
    • Dan Williams's avatar
      release: update NEWS · 7b492bb5
      Dan Williams authored
      7b492bb5
    • Dan Williams's avatar
      gsm: fix return value of SMS send method · e88270ee
      Dan Williams authored
      The introspection data specified the Send() method to return
      an array of unsigned integers, presumably the indexes of the
      messages just sent.  But the code wasn't doing that, leading
      to a crash when dbus-glib tried to interpret garbage on the
      return.
      
      The problem is that sms_send_auth_cb() gave async_call_done()
      as the callback for sending the SMS, but that method just calls
      dbus_g_method_return() with no return arguments.  dbus-glib
      interprets the arguments of dbus_g_method_return() according
      to the XML introspection data, and thus it was attempting to
      read the non-existent argument as an 'au' and getting garbage.
      
      Fix that by actually returning an array of message indexes from
      the SMS send code, and propagate that back to the SMS dbus
      code so it can return something sensible.
      e88270ee
Loading