Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • X xf86-video-amdgpu
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 0
    • Merge requests 0
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar

Due to an influx of spam, we have had to impose restrictions on new accounts. Please see this wiki page for instructions on how to get full permissions. Sorry for the inconvenience.

  • Pierre-Eric Pelloux-Prayer
  • xf86-video-amdgpu
  • Merge requests
  • !1

glamor: don't fail create_pixmap for depth=30

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Pierre-Eric Pelloux-Prayer requested to merge dont_fail_30bits_pixmap into master Oct 21, 2021
  • Overview 0
  • Commits 1
  • Pipelines 1
  • Changes 1

xf86GetPixFormat has a hardcoded list of format, and there's no 30 bits format there.

But the format isn't needed to actually create the pixmap, so make a NULL format a non-failure case.

This fixes an application trying to create a pbuffer using the first config from glXChooseFBConfig(...GLX_PBUFFER_BIT...). This config happens to be a 30 bits one and without this change the app would exit with a BadAlloc error.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: dont_fail_30bits_pixmap